Merge lp:~brunonova/ubuntu/quantal/software-properties/lp1075537 into lp:ubuntu/quantal-proposed/software-properties

Proposed by Bruno on 2013-12-06
Status: Rejected
Rejected by: Brian Murray on 2013-12-07
Proposed branch: lp:~brunonova/ubuntu/quantal/software-properties/lp1075537
Merge into: lp:ubuntu/quantal-proposed/software-properties
Diff against target: 19 lines (+2/-0)
1 file modified
softwareproperties/gtk/SoftwarePropertiesGtk.py (+2/-0)
To merge this branch: bzr merge lp:~brunonova/ubuntu/quantal/software-properties/lp1075537
Reviewer Review Type Date Requested Status
Brian Murray 2013-12-06 Disapprove on 2013-12-07
Review via email: mp+198137@code.launchpad.net

Description of the change

Fix for bug LP: #1075537 (which was fixed in Saucy) "backported" to Quantal.

I tested this quickly in Virtualbox, and it seems to be working (the fix is trivial).

To test it, just run the fixed version of software-properties-gtk, change something in the software sources (the "Revert" button should become enabled), and close.
A dialog allowing the apt cache to be refreshed should appear.

I didn't change the changelogs or anything else in debian/*.

To post a comment you must log in.
Brian Murray (brian-murray) wrote :

I'm disapproving this due to the pending EOL of Quantal and the scope of impact of the bug.

review: Disapprove

Unmerged revisions

95. By Bruno on 2013-12-06

Ensure software sources are refreshed after modification (LP: #1075537)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'softwareproperties/gtk/SoftwarePropertiesGtk.py'
2--- softwareproperties/gtk/SoftwarePropertiesGtk.py 2013-02-26 17:21:44 +0000
3+++ softwareproperties/gtk/SoftwarePropertiesGtk.py 2013-12-06 23:37:25 +0000
4@@ -765,6 +765,7 @@
5 """The config was changed and now needs to be saved and reloaded"""
6 apt.apt_pkg.init_config()
7 self.button_revert.set_sensitive(True)
8+ self.modified_sourceslist = True
9
10 def on_keys_modified(self):
11 """ The apt keys have changed and need to be redisplayed """
12@@ -777,6 +778,7 @@
13 self.show_isv_sources()
14 self.show_cdrom_sources()
15 self.button_revert.set_sensitive(True)
16+ self.modified_sourceslist = True
17
18 def on_auth_failed(self):
19 """ send when the authentication failed """

Subscribers

People subscribed via source and target branches

to all changes: