Merge lp:~brunonova/software-properties/update-apt-on-exit into lp:software-properties

Proposed by Bruno Nova
Status: Merged
Merged at revision: 881
Proposed branch: lp:~brunonova/software-properties/update-apt-on-exit
Merge into: lp:software-properties
Diff against target: 19 lines (+2/-0)
1 file modified
softwareproperties/gtk/SoftwarePropertiesGtk.py (+2/-0)
To merge this branch: bzr merge lp:~brunonova/software-properties/update-apt-on-exit
Reviewer Review Type Date Requested Status
Michael Vogt (community) Approve
Review via email: mp+190498@code.launchpad.net

Description of the change

Fixes Bug #1075537 (and, indirectly, Bug #782953 it seems).

The apt cache was not being updated on exit, because the "modified_sourceslist" variable in the file "softwareproperties/gtk/SoftwarePropertiesGtk.py" was not being set correctly (it was never set to True). This was fixed, I hope.
Tested in Ubuntu 13.04 by replacing the installed version of the file (in /usr/lib/python3/dist-packages/softwareproperties/gtk/SoftwarePropertiesGtk.py) with this new one. It worked in my tests (not many tests), and update dialog appeared on exit.

Apparently, this also fixes Bug #782953 in the Software Center.
When software-properties-gtk is run by Software Center, it "grabs" (and hides) the update dialog and shows the update progress inside the Software Center.
It, then, runs "update-apt-xapian-index" correctly.

To post a comment you must log in.
Revision history for this message
Michael Vogt (mvo) wrote :

Thanks, this looks good.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'softwareproperties/gtk/SoftwarePropertiesGtk.py'
2--- softwareproperties/gtk/SoftwarePropertiesGtk.py 2013-05-29 11:25:47 +0000
3+++ softwareproperties/gtk/SoftwarePropertiesGtk.py 2013-10-10 22:25:52 +0000
4@@ -782,6 +782,7 @@
5 """The config was changed and now needs to be saved and reloaded"""
6 apt.apt_pkg.init_config()
7 self.button_revert.set_sensitive(True)
8+ self.modified_sourceslist = True
9
10 def on_keys_modified(self):
11 """ The apt keys have changed and need to be redisplayed """
12@@ -794,6 +795,7 @@
13 self.show_isv_sources()
14 self.show_cdrom_sources()
15 self.button_revert.set_sensitive(True)
16+ self.modified_sourceslist = True
17
18 def on_auth_failed(self):
19 """ send when the authentication failed """

Subscribers

People subscribed via source and target branches

to status/vote changes: