Merge lp:~brunonova/software-properties/remove-unnecessary-line into lp:software-properties

Proposed by Bruno Nova
Status: Merged
Merged at revision: 889
Proposed branch: lp:~brunonova/software-properties/remove-unnecessary-line
Merge into: lp:software-properties
Diff against target: 11 lines (+0/-1)
1 file modified
softwareproperties/gtk/SoftwarePropertiesGtk.py (+0/-1)
To merge this branch: bzr merge lp:~brunonova/software-properties/remove-unnecessary-line
Reviewer Review Type Date Requested Status
Brian Murray Approve
Review via email: mp+198325@code.launchpad.net

Description of the change

The line "self.modified_sourceslist = True" that I added in method on_config_modified() in SoftwarePropertiesGtk.py (merged in commit 881) is not needed, so I'm removing it in this commit.

The impact of that line was minimal: the combo boxes in the "Updates" tab have no effect on the sources list, but changing their values (and nothing else) would make the dialog asking for the apt cache to be reloaded appear when closing the window, and there's no need for that (I guess).

I tested changing the other options in the first 3 tabs, and they all still made the "apt reload" dialog appear correctly on close.

To post a comment you must log in.
Revision history for this message
Brian Murray (brian-murray) wrote :

This looks good, thanks for following up!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'softwareproperties/gtk/SoftwarePropertiesGtk.py'
2--- softwareproperties/gtk/SoftwarePropertiesGtk.py 2013-10-21 15:13:30 +0000
3+++ softwareproperties/gtk/SoftwarePropertiesGtk.py 2013-12-09 23:26:53 +0000
4@@ -782,7 +782,6 @@
5 """The config was changed and now needs to be saved and reloaded"""
6 apt.apt_pkg.init_config()
7 self.button_revert.set_sensitive(True)
8- self.modified_sourceslist = True
9
10 def on_keys_modified(self):
11 """ The apt keys have changed and need to be redisplayed """

Subscribers

People subscribed via source and target branches

to status/vote changes: