Code review comment for lp:~brunonova/software-properties/lp1381050_2

Revision history for this message
Bruno Nova (brunonova) wrote :

I just booted the Wily Daily Live ISO, patched the system SoftwareProperties.py file directly, then started software-properties-gtk and added the VLC key that I downloaded to "~/Transferências" (and I also renamed the key file so it contained accented characters).
It worked! The key was added successfully.

Why didn't it work for you? 'path.encode("utf-8")' failed on your system.
Did you test this on a system without UTF-8 support?

Any ideas?

I think the code of the method should be all inside of the try...except method, so that the method always returns and the GUI can show an error message, instead of failing silently. The 'except' block should also print the stack trace.
This won't fix the bug, but is an improvement I think.

« Back to merge proposal