Code review comment for lp:~brunonova/software-properties/lp1381050

On Thu, Jan 29, 2015 at 12:29:09PM -0000, Bruno Nova wrote:
> @Michael
> I completely forgot about these bugs!
>
> I cloned/branched lp:software-properties and tested it, and the fix seems to be working correctly.
> My test: I killed the running software-properties-dbus process then started, as root, the fixed one from the cloned branch. Then I ran software-properties-gtk and added/removed the VLC key from my "~/Transferências" folder, and it worked.
> I also tested lp:ubuntu/software-properties successfully.
> So, either you fixed the issue I mentioned, or I was wrong. :)

Thanks a lot for confirming, I'm too lazy^Wbusy to check what fixed
it, but I'm very happy its fixed :)

> Also, bug #1383289 is fixed, so could you mark it as fixed (it wasn't marked automatically).
> And we should backport these fixes to Utopic and Trusty.

I created a trusty task, not sure about utopic. If you have time, it
would be awesome if you could create a diff for a SRU upload. I'm
happy to sponsor the upload but unfortunately I'm pretty busy right
now so not much time to prepare/test a diff myself :/

Thanks!
 Michael