Merge lp:~broder/ubuntu/lucid/update-inetd/fix-601732 into lp:ubuntu/lucid/update-inetd

Proposed by Evan Broder on 2010-11-12
Status: Merged
Merged at revision: 5
Proposed branch: lp:~broder/ubuntu/lucid/update-inetd/fix-601732
Merge into: lp:ubuntu/lucid/update-inetd
Diff against target: 33 lines (+14/-1)
2 files modified
DebianNet.pm (+7/-1)
debian/changelog (+7/-0)
To merge this branch: bzr merge lp:~broder/ubuntu/lucid/update-inetd/fix-601732
Reviewer Review Type Date Requested Status
Dave Walker 2010-11-12 Approve on 2010-12-03
Review via email: mp+40737@code.launchpad.net
To post a comment you must log in.
Dave Walker (davewalker) wrote :

Patch looks like it has been cherry picked from debian's 4.37, http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=589487

The patch also seems to be applied in our Maverick package. I have not reproduced the bug on Lucid, but based on it being a known issue; fixed in both Debian and Maverick - I am inclined to approve.

The package does build.

review: Approve
Dave Walker (davewalker) wrote :

Seems it was already in lucid-proposed... oops.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'DebianNet.pm'
2--- DebianNet.pm 2009-09-20 16:51:37 +0000
3+++ DebianNet.pm 2010-11-12 16:17:48 +0000
4@@ -323,7 +323,13 @@
5 &printv("About to $action inetd via invoke-rc.d\n");
6 my $service = $1;
7 unless ($fake_invocation) {
8- system("invoke-rc.d $service $action >/dev/null");
9+ # If we were called by a shell script that also uses
10+ # debconf, the pipe to the debconf frontend is fd 3 as
11+ # well as fd 1 (stdout). Ensure that fd 3 is not
12+ # inherited by invoke-rc.d and inetd, as that will
13+ # cause debconf to hang (bug #589487). Don't let them
14+ # confuse debconf via stdout either.
15+ system("invoke-rc.d $service $action >/dev/null 3>&-");
16 }
17 }
18 }
19
20=== modified file 'debian/changelog'
21--- debian/changelog 2009-09-27 12:15:15 +0000
22+++ debian/changelog 2010-11-12 16:17:48 +0000
23@@ -1,3 +1,10 @@
24+update-inetd (4.35ubuntu0.1) lucid-proposed; urgency=low
25+
26+ * Workaround debconf hanging by closing fd 3 in invoke-rc.d invocation
27+ (LP: #601732) Patch from Ben Hutchings <ben@decadent.org.uk>
28+
29+ -- Evan Broder <evan@ebroder.net> Fri, 12 Nov 2010 08:13:33 -0800
30+
31 update-inetd (4.35) unstable; urgency=low
32
33 * Add missing dependencies on libfile-temp-perl (which, is provided by the

Subscribers

People subscribed via source and target branches

to all changes: