Merge lp:~broder/ubuntu-dev-tools/fix-1106429 into lp:~ubuntu-dev/ubuntu-dev-tools/trunk

Proposed by Evan Broder
Status: Merged
Merged at revision: 1392
Proposed branch: lp:~broder/ubuntu-dev-tools/fix-1106429
Merge into: lp:~ubuntu-dev/ubuntu-dev-tools/trunk
Diff against target: 31 lines (+9/-2)
2 files modified
backportpackage (+3/-1)
debian/changelog (+6/-1)
To merge this branch: bzr merge lp:~broder/ubuntu-dev-tools/fix-1106429
Reviewer Review Type Date Requested Status
Martin Pitt Approve
Review via email: mp+173850@code.launchpad.net

Description of the change

I'm not wild about this logic, but it seemed like the best way to distinguish redirects that were OK from redirects that were not.

To post a comment you must log in.
Revision history for this message
Dmitry Shachnev (mitya57) wrote :

FWIW, the trailing backslash is not needed when you are inside (...).

1392. By Evan Broder

Only conclude that we don't need an orig tarball if we're sent to the
librarian (as opposed to the login page from a private PPA). (LP:
#1106429)

Revision history for this message
Evan Broder (broder) wrote :

Thanks for the pointer - just pushed a tweak

Revision history for this message
Martin Pitt (pitti) wrote :

Thanks! Merged.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'backportpackage'
2--- backportpackage 2013-05-24 19:58:12 +0000
3+++ backportpackage 2013-07-12 20:41:27 +0000
4@@ -291,7 +291,9 @@
5 % (user, ppa, filename))
6 try:
7 headers, body = h.request(url, 'HEAD')
8- if headers.status != 200:
9+ if (headers.status != 200 or
10+ not headers['content-location'].
11+ startswith('https://launchpadlibrarian.net')):
12 return True
13 except HttpLib2Error, e:
14 Logger.info(e)
15
16=== modified file 'debian/changelog'
17--- debian/changelog 2013-05-24 19:58:12 +0000
18+++ debian/changelog 2013-07-12 20:41:27 +0000
19@@ -10,7 +10,12 @@
20 [ Adam Gandelman ]
21 * backportpackage: Fix destination for --dont-sign option. (LP: #1183985)
22
23- -- Adam Gandelman <adamg@ubuntu.com> Fri, 24 May 2013 12:56:08 -0700
24+ [ Evan Broder ]
25+ * Only conclude that we don't need an orig tarball if we're sent to the
26+ librarian (as opposed to the login page from a private PPA). (LP:
27+ #1106429)
28+
29+ -- Evan Broder <evan@stripe.com> Tue, 09 Jul 2013 17:49:21 -0700
30
31 ubuntu-dev-tools (0.148) unstable; urgency=low
32

Subscribers

People subscribed via source and target branches

to status/vote changes: