Merge lp:~brianaker/libmemcached/1251482 into lp:libmemcached/1.0

[Brian Aker]

[Brian Aker (brianaker)]

review: Approve

[lp:~brianaker/libmemcached/1251482]

1173. By Tangent.Org Continuous Integration on 2013-12-19

Merge lp:~brianaker/libmemcached/1251482 Build: jenkins-Libmemcached-404

=== modified file 'ChangeLog'
--- ChangeLog	2013-04-23 08:03:33 +0000
+++ ChangeLog	2013-11-23 03:07:18 +0000
@@ -1,4 +1,5 @@
 1.0.18
+* MEMCACHED_BEHAVIOR_RETRY_TIMEOUT can now be set to zero.
 
 1.0.17 Tue Apr  2 14:02:01 HST 2013
 * Remove c++ namespace that was being exposed (the API should be plug compatible)..

=== modified file 'bootstrap.sh'
--- bootstrap.sh	2013-10-18 07:06:29 +0000
+++ bootstrap.sh	2013-11-23 03:07:18 +0000
@@ -404,6 +404,10 @@
   # Arguments for configure
   local BUILD_CONFIGURE_ARG='' 
 
+  if $jenkins_build_environment; then
+    BUILD_CONFIGURE_ARG="--disable-silent-rules "
+  fi
+
   # If debug is set we enable both debug and asssert, otherwise we see if this is a VCS checkout and if so enable assert
   # Set ENV ASSERT in order to enable assert.
   # If we are doing a valgrind run, we always compile with assert disabled

=== modified file 'configure.ac'
--- configure.ac	2013-11-04 11:17:45 +0000
+++ configure.ac	2013-11-23 03:07:18 +0000
@@ -47,17 +47,20 @@
 m4_include([libhashkit/include.m4])
 
 LT_PREREQ([2.2])
-LT_INIT
+LT_INIT([dlopen])
 LT_LANG([C++])
 LT_LIB_M
 
+AC_SUBST([lt_cv_dlopen_libs])
+
+
 AC_PROG_CC_C99
 AS_IF([test "x${ac_cv_prog_cc_c99}" == "xno"],[AC_MSG_ERROR([No c99 compatible compiler found])])
 
 AC_DEFUN([CHECK_CXX0X],[
           AC_LANG_PUSH([C++])
           AX_CHECK_COMPILE_FLAG([-std=c++0x],[
-                                 CXXFLAGS="$CXXFLAGS -std=c++0x"])
+                                 CXX="$CXX -std=c++0x"])
           AC_LANG_POP([C++])
           ])
 CHECK_CXX0X
@@ -68,10 +71,6 @@
 
 m4_ifdef([AM_SILENT_RULES],[AM_SILENT_RULES([yes])])
 
-AX_CXX_HEADER_STDCXX_98
-AS_IF([test "x$ax_cv_cxx_stdcxx_98" = "xno"],
-      [AC_MSG_ERROR([Your system lacks a new enough C++ compiler])])
-
 AC_DEFUN([LIBMEMCACHED_PROTOCOL],
          [AC_ARG_ENABLE([libmemcachedprotocol],
                         [AS_HELP_STRING([--enable-libmemcachedprotocol],
@@ -254,9 +253,6 @@
              [AC_DEFINE([HAVE_CLOCK_GETTIME],[0],[Have clock_gettime])])
 
 
-# Check for the ability to call dlopen (used in libhostile)
-AX_DLOPEN
-
 AC_CHECK_HEADERS([atomic.h])
 AS_IF([test "x$ac_cv_header_atomic_h" = "xyes"],
       [AC_CHECK_FUNCS([atomic_add_64])
@@ -297,8 +293,10 @@
 AX_UUID_GENERATE_TIME_SAFE
 
 AC_DEFUN([CHECK_FOR_PTHREAD_AND_SASL],
-         [AX_PTHREAD(, [AC_MSG_ERROR([could not find libpthread])])
+         [AC_LANG_PUSH([C++])
+         AX_PTHREAD(, [AC_MSG_ERROR([could not find libpthread])])
          AX_PTHREAD_TIMEDJOIN_NP
+         AC_LANG_POP([C++])
 
          # The sasl functions should only be visible if we build with sasl support
          #

=== modified file 'libmemcached/behavior.cc'
--- libmemcached/behavior.cc	2013-03-31 23:24:29 +0000
+++ libmemcached/behavior.cc	2013-11-23 03:07:18 +0000
@@ -230,11 +230,6 @@
     break;
 
   case MEMCACHED_BEHAVIOR_RETRY_TIMEOUT:
-    if (data == 0)
-    {
-      return memcached_set_error(*ptr, MEMCACHED_INVALID_ARGUMENTS, MEMCACHED_AT,
-                                        memcached_literal_param("MEMCACHED_BEHAVIOR_RETRY_TIMEOUT requires a value greater then zero."));
-    }
     ptr->retry_timeout= int32_t(data);
     break;
 

=== modified file 'libmemcached/include.am'
--- libmemcached/include.am	2013-02-04 07:38:04 +0000
+++ libmemcached/include.am	2013-11-23 03:07:18 +0000
@@ -2,7 +2,7 @@
 # included from Top Level Makefile.am
 # All paths should be given relative to the root
 
-libmemcached_libmemcached_la_SOURCES =
+libmemcached_libmemcached_la_SOURCES=
 
 include libmemcached/csl/include.am
 
@@ -56,8 +56,11 @@
 EXTRA_libmemcached_libmemcached_la_DEPENDENCIES=
 libmemcached_libmemcached_la_LIBADD=
 libmemcached_libmemcached_la_LDFLAGS=
-libmemcached_libmemcached_la_CFLAGS= -DBUILDING_LIBMEMCACHED
-libmemcached_libmemcached_la_CXXFLAGS= -DBUILDING_LIBMEMCACHED
+libmemcached_libmemcached_la_CFLAGS=
+libmemcached_libmemcached_la_CXXFLAGS=
+
+libmemcached_libmemcached_la_CFLAGS+= -DBUILDING_LIBMEMCACHED
+libmemcached_libmemcached_la_CXXFLAGS+= -DBUILDING_LIBMEMCACHED
 
 if BUILD_WIN32
 libmemcached_libmemcached_la_CFLAGS+= -DBUILDING_HASHKIT
@@ -122,12 +125,13 @@
 libmemcached/options.cc: libmemcached/csl/parser.h
 
 libmemcached_libmemcached_la_LDFLAGS+= -version-info ${MEMCACHED_LIBRARY_VERSION}
-libmemcached_libmemcached_la_LIBADD+= @DL_LIB@
+libmemcached_libmemcached_la_LIBADD+= @lt_cv_dlopen_libs@
 
 if HAVE_SASL
+libmemcached_libmemcached_la_CFLAGS+= @PTHREAD_CFLAGS@
 libmemcached_libmemcached_la_CXXFLAGS+= @PTHREAD_CFLAGS@
 libmemcached_libmemcached_la_LIBADD+= @PTHREAD_LIBS@
-libmemcached_libmemcached_la_LIBADD+= @LIBSASL_LIB@
+libmemcached_libmemcached_la_LIBADD+= @SASL_LIB@
 endif
 
 if HAVE_DTRACE

=== modified file 'libmemcached/server.hpp'
--- libmemcached/server.hpp	2013-03-31 23:24:29 +0000
+++ libmemcached/server.hpp	2013-11-23 03:07:18 +0000
@@ -76,17 +76,20 @@
 {
   if (server->state != MEMCACHED_SERVER_STATE_IN_TIMEOUT)
   {
-    struct timeval next_time;
-    if (gettimeofday(&next_time, NULL) == 0)
-    {
-      server->next_retry= next_time.tv_sec +server->root->retry_timeout;
-    }
-    else
-    {
-      server->next_retry= 1; // Setting the value to 1 causes the timeout to occur immediatly
-    }
+    if (server->root->retry_timeout != 0)
+    {
+      struct timeval next_time;
+      if (gettimeofday(&next_time, NULL) == 0)
+      {
+        server->next_retry= next_time.tv_sec +server->root->retry_timeout;
+      }
+      else
+      {
+        server->next_retry= 1; // Setting the value to 1 causes the timeout to occur immediatly
+      }
 
-    server->state= MEMCACHED_SERVER_STATE_IN_TIMEOUT;
+      server->state= MEMCACHED_SERVER_STATE_IN_TIMEOUT;
+    }
     if (server->server_failure_counter_query_id != server->root->query_id)
     {
       server->server_failure_counter++;

=== modified file 'libtest/include.am'
--- libtest/include.am	2013-05-03 07:36:06 +0000
+++ libtest/include.am	2013-11-23 03:07:18 +0000
@@ -170,8 +170,10 @@
 # We are either building in tree, or with
 libtest_libtest_la_SOURCES+= libtest/memcached.cc
 
+if HAVE_LIBDRIZZLE
 libtest_libtest_la_LDFLAGS+= @LIBDRIZZLE_LDFLAGS@
 libtest_libtest_la_LIBADD+= @LIBDRIZZLE_LIB@
+endif
 
 libtest_libtest_la_SOURCES+= libtest/gearmand.cc
 
@@ -244,7 +246,7 @@
 libtest_backtrace_LDADD=
 libtest_backtrace_SOURCES+= libtest/backtrace_test.cc
 libtest_backtrace_SOURCES+= libmemcached/backtrace.cc
-libtest_backtrace_LDADD+= @DL_LIB@
+libtest_backtrace_LDADD+= @lt_cv_dlopen_libs@
 noinst_PROGRAMS+= libtest/backtrace
 test-backtrace: libtest/backtrace
 	@libtest/backtrace

=== modified file 'm4/ax_check_library.m4'
--- m4/ax_check_library.m4	2013-01-08 01:03:28 +0000
+++ m4/ax_check_library.m4	2013-11-23 03:07:18 +0000
@@ -87,9 +87,6 @@
 
     AS_IF([test "$]AS_TR_SH([ax_cv_have_]$1)[" = "yes"],
         [AC_DEFINE([HAVE_]$1, [1], [Define to 1 if ]$1[ is found])
-        AC_SUBST($1[_CPPFLAGS])
-        AC_SUBST($1[_LDFLAGS])
-        AC_SUBST($1[_LIB],[-l]$3)
         ifelse([$4], , :, [$4])],
         [ifelse([$5], , :, [$5])])
     ])

=== removed file 'm4/ax_dlopen.m4'
--- m4/ax_dlopen.m4	2013-01-08 01:03:28 +0000
+++ m4/ax_dlopen.m4	1970-01-01 00:00:00 +0000
@@ -1,10 +0,0 @@
-#serial 2
-
-AC_DEFUN([AX_DLOPEN],
-    [AS_IF([test "x$enable_shared" = xyes],
-      [AX_CHECK_LIBRARY([DL],[dlfcn.h],[dl],
-        [AC_DEFINE([HAVE_LIBDL],[1],[Have dlopen])
-        AC_CHECK_LIB([dl],[dlopen],[AC_DEFINE([HAVE_DLOPEN],[1],[Have dlopen])])
-        AC_CHECK_LIB([dl],[dladdr],[AC_DEFINE([HAVE_DLADDR],[1],[Have dladdr])])])])
-    ])
-

=== modified file 'm4/ax_pthread.m4'
--- m4/ax_pthread.m4	2013-11-04 11:17:45 +0000
+++ m4/ax_pthread.m4	2013-11-23 03:07:18 +0000
@@ -87,7 +87,6 @@
 AU_ALIAS([ACX_PTHREAD], [AX_PTHREAD])
 AC_DEFUN([AX_PTHREAD], [
 AC_REQUIRE([AC_CANONICAL_HOST])
-AC_LANG_PUSH([C])
 ax_pthread_ok=no
 
 # We used to check for pthread.h first, but this fails if pthread.h
@@ -328,5 +327,4 @@
         ax_pthread_ok=no
         $2
 fi
-AC_LANG_POP
 ])dnl AX_PTHREAD

=== modified file 'm4/ax_sasl.m4'
--- m4/ax_sasl.m4	2012-12-13 02:48:43 +0000
+++ m4/ax_sasl.m4	2013-11-23 03:07:18 +0000
@@ -20,33 +20,32 @@
 #   and this notice are preserved. This file is offered as-is, without any
 #   warranty.
 
-#serial 2
+#serial 3
 
 AC_DEFUN([AX_SASL_OPTION],
-    [AC_REQUIRE([AX_SASL_CHECK])
-    AC_ARG_ENABLE([sasl],
-      [AS_HELP_STRING([--disable-sasl], [Build with sasl support @<:@default=on@:>@])],
-      [ac_enable_sasl="$enableval"],
-      [ac_enable_sasl=yes])
-
-    AS_IF([test "x${ac_enable_sasl}" = xyes],
-      [AC_MSG_CHECKING([checking to see if enabling sasl])
-      AS_IF([test "x${ax_sasl_check}" = xyes],
-        [ax_sasl_option=yes],
-        [AC_MSG_WARN([request to add sasl support failed, please see config.log])
-        ac_enable_sasl=no
-        ax_sasl_option=no])
-      AC_MSG_RESULT(["$ax_sasl_option"])
-      ])
-    AM_CONDITIONAL([HAVE_SASL],[test "x${ax_sasl_option}" = xyes])
-    ])
-
-AC_DEFUN([AX_SASL_CHECK],
-    [ax_sasl_check=no
-    AX_CHECK_LIBRARY([LIBSASL],[sasl/sasl.h],[sasl2],
-      [ax_sasl_check=yes
-      AC_SUBST([SASL_LIB],[[-lsasl2]])
-      ])
-    AC_MSG_CHECKING([checking to see if sasl works])
-    AC_MSG_RESULT(["$ax_sasl_check"])
-    ])
+         [AC_REQUIRE([AX_SASL_CHECK])
+         AC_ARG_ENABLE([sasl],
+                       [AS_HELP_STRING([--disable-sasl], [Build with sasl support @<:@default=on@:>@])],
+                       [ac_enable_sasl="$enableval"],
+                       [ac_enable_sasl=yes])
+
+         AS_IF([test "x${ac_enable_sasl}" = xyes],[
+               AC_MSG_CHECKING([checking to see if enabling sasl])
+               AS_IF([test "x${ax_sasl_check}" = xyes],[
+                     ax_sasl_option=yes],[
+                     AC_MSG_WARN([request to add sasl support failed, please see config.log])
+                     ac_enable_sasl=no
+                     ax_sasl_option=no])
+               AC_MSG_RESULT(["$ax_sasl_option"])],[
+               ax_sasl_option=no])
+         AM_CONDITIONAL([HAVE_SASL],[test "x${ax_sasl_option}" = xyes])
+         ])
+
+AC_DEFUN([AX_SASL_CHECK],[
+         AX_CHECK_LIBRARY([LIBSASL],[sasl/sasl.h],[sasl2],[
+                          ax_sasl_check=yes
+                          AC_SUBST([SASL_LIB],[[-lsasl2]])],[
+                          ax_sasl_check=no])
+         AC_MSG_CHECKING([checking to see if sasl works])
+         AC_MSG_RESULT(["$ax_sasl_check"])
+         ])

=== modified file 'tests/include.am'
--- tests/include.am	2013-04-29 15:24:05 +0000
+++ tests/include.am	2013-11-23 03:07:18 +0000
@@ -27,10 +27,10 @@
 # Cycle should always run first
 tests_cycle_CFLAGS= $(AM_CFLAGS) $(NO_CONVERSION) $(NO_STRICT_ALIASING)
 tests_cycle_CXXFLAGS= $(AM_CXXFLAGS)
-tests_cycle_CXXFLAGS+= ${PTHREAD_CFLAGS}
+tests_cycle_CXXFLAGS+= @PTHREAD_CFLAGS@
 tests_cycle_SOURCES= tests/cycle.cc
 tests_cycle_LDADD= $(TESTS_LDADDS)
-tests_cycle_LDADD+= ${PTHREAD_LIBS}
+tests_cycle_LDADD+= @PTHREAD_LIBS@
 check_PROGRAMS+= tests/cycle
 noinst_PROGRAMS+= tests/cycle
 

=== modified file 'tests/libmemcached-1.0/all_tests.h'
--- tests/libmemcached-1.0/all_tests.h	2013-09-15 07:19:20 +0000
+++ tests/libmemcached-1.0/all_tests.h	2013-11-23 03:07:18 +0000
@@ -284,6 +284,7 @@
   {"lp:1021819", true, (test_callback_fn*)regression_1021819_TEST },
   {"lp:1048945", true, (test_callback_fn*)regression_1048945_TEST },
   {"lp:1067242", true, (test_callback_fn*)regression_1067242_TEST },
+  {"lp:1251482", true, (test_callback_fn*)regression_bug_1251482 },
   {0, false, (test_callback_fn*)0}
 };
 

=== modified file 'tests/libmemcached-1.0/mem_functions.cc'
--- tests/libmemcached-1.0/mem_functions.cc	2013-11-04 11:17:45 +0000
+++ tests/libmemcached-1.0/mem_functions.cc	2013-11-23 03:07:18 +0000
@@ -4559,7 +4559,7 @@
 
   /* Put a retry timeout to effectively activate failure_limit effect */
   test_compare(MEMCACHED_SUCCESS,
-               memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_RETRY_TIMEOUT, true));
+               memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_RETRY_TIMEOUT, 1));
 
   /* change behavior that triggers memcached_quit()*/
   test_compare(MEMCACHED_SUCCESS,
@@ -4841,6 +4841,28 @@
   return TEST_SUCCESS;
 }
 
+test_return_t regression_bug_1251482(memcached_st*)
+{
+  test::Memc memc("--server=localhost:5");
+
+  memcached_behavior_set(&memc, MEMCACHED_BEHAVIOR_RETRY_TIMEOUT, 0);
+
+  for (size_t x= 4; x; --x)
+  {
+    size_t value_length;
+    memcached_return_t rc;
+    char *value= memcached_get(&memc,
+                               test_literal_param(__func__),
+                               &value_length, NULL, &rc);
+
+    test_false(value);
+    test_compare(0LLU, value_length);
+    test_compare(MEMCACHED_CONNECTION_FAILURE, rc);
+  }
+
+  return TEST_SUCCESS;
+}
+
 test_return_t regression_1009493_TEST(memcached_st*)
 {
   memcached_st* memc= memcached_create(NULL);

=== modified file 'tests/libmemcached-1.0/mem_functions.h'
--- tests/libmemcached-1.0/mem_functions.h	2013-09-15 07:19:20 +0000
+++ tests/libmemcached-1.0/mem_functions.h	2013-11-23 03:07:18 +0000
@@ -187,3 +187,4 @@
 test_return_t regression_1048945_TEST(memcached_st*);
 test_return_t regression_1067242_TEST(memcached_st*);
 test_return_t comparison_operator_memcached_st_and__memcached_return_t_TEST(memcached_st*);
+test_return_t regression_bug_1251482(memcached_st*);