Merge lp:~brian.curtin/ubuntuone-windows-installer/remove-lazr-mentions into lp:ubuntuone-windows-installer

Proposed by Brian Curtin on 2012-10-15
Status: Merged
Approved by: Brian Curtin on 2012-10-15
Approved revision: 144
Merged at revision: 144
Proposed branch: lp:~brian.curtin/ubuntuone-windows-installer/remove-lazr-mentions
Merge into: lp:ubuntuone-windows-installer
Diff against target: 23 lines (+1/-5)
1 file modified
scripts/setup.py (+1/-5)
To merge this branch: bzr merge lp:~brian.curtin/ubuntuone-windows-installer/remove-lazr-mentions
Reviewer Review Type Date Requested Status
Roberto Alsina (community) Approve on 2012-10-16
Mike McCracken (community) 2012-10-15 Approve on 2012-10-15
Review via email: mp+129765@code.launchpad.net

Commit Message

- Remove lazr and wadllib mentions from setup.py

Description of the Change

Remove any mentions of lazr/wadllib from the setup script, as these are no longer used.

To post a comment you must log in.
Mike McCracken (mikemc) wrote :

Code review only, looks fine. setup-mac includes none of these packages so I'm comfortable killing them here.

review: Approve
Roberto Alsina (ralsina) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'scripts/setup.py'
2--- scripts/setup.py 2012-09-14 21:07:48 +0000
3+++ scripts/setup.py 2012-10-15 21:20:26 +0000
4@@ -48,7 +48,7 @@
5 # pylint: disable=E1101
6 # pylint: disable=W0231
7 class MediaCollector(build_exe):
8- """Extension that copies lazr missing data."""
9+ """Extension that copies missing data."""
10
11 def __init__(self, *args, **kwargs):
12 """Create a new instance."""
13@@ -82,10 +82,6 @@
14 """Copy the missing extensions."""
15 build_exe.copy_extensions(self, extensions)
16 for module in [
17- 'lazr.uri',
18- 'lazr.restfulclient',
19- 'lazr.authentication',
20- 'wadllib',
21 'ubuntuone.storageprotocol',
22 ]:
23 self._add_module_data(module)

Subscribers

People subscribed via source and target branches