Merge lp:~brian.curtin/ubuntuone-control-panel/jenkins-fix into lp:ubuntuone-control-panel

Proposed by Brian Curtin
Status: Merged
Approved by: Manuel de la Peña
Approved revision: no longer in the source branch.
Merged at revision: 327
Proposed branch: lp:~brian.curtin/ubuntuone-control-panel/jenkins-fix
Merge into: lp:ubuntuone-control-panel
Diff against target: 27 lines (+3/-0)
1 file modified
ubuntuone/controlpanel/utils/tests/test_windows.py (+3/-0)
To merge this branch: bzr merge lp:~brian.curtin/ubuntuone-control-panel/jenkins-fix
Reviewer Review Type Date Requested Status
Manuel de la Peña (community) Approve
Review via email: mp+105980@code.launchpad.net

Commit message

- Add skipIfJenkins decorator to two tests which only fail on the Jenkins setup

Description of the change

Use the new Jenkins skip decorator to skip two tests that fail due to permissions on the Windows jenkins machine.

To post a comment you must log in.
Revision history for this message
Manuel de la Peña (mandel) wrote :

Great! lets get those tests out for jenkins.

review: Approve
327. By Brian Curtin

- Add skipIfJenkins decorator to two tests which only fail on the Jenkins setup

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ubuntuone/controlpanel/utils/tests/test_windows.py'
2--- ubuntuone/controlpanel/utils/tests/test_windows.py 2012-04-05 14:52:55 +0000
3+++ ubuntuone/controlpanel/utils/tests/test_windows.py 2012-05-16 14:05:24 +0000
4@@ -23,6 +23,7 @@
5
6 from ubuntuone.controlpanel import utils
7 from ubuntuone.controlpanel.tests import TestCase
8+from ubuntuone.devtools.testcases import skipIfJenkins
9
10 # let me use protected methods
11 # pylint: disable=W0212
12@@ -206,6 +207,7 @@
13 class DefaultFoldersTestCase(TestCase):
14 """Test the default_folders method."""
15
16+ @skipIfJenkins("win32", "Fails due to Jenkins setup on Windows")
17 def test_special_folders(self, names=None):
18 """Test that default_folders does the right thing."""
19 folders = utils.default_folders()
20@@ -224,6 +226,7 @@
21
22 self.assertEqual(sorted(folders), sorted(expected))
23
24+ @skipIfJenkins("win32", "Fails due to Jenkins setup on Windows")
25 def test_special_folders_with_error(self):
26 """Test that default_folders handles errors."""
27 failing_name = 'MYVIDEO'

Subscribers

People subscribed via source and target branches