lp:~brian.curtin/ubuntuone-client/820350-fix-readonly-readwrite

Created by Brian Curtin on 2012-02-07 and last modified on 2012-02-10
Get this branch:
bzr branch lp:~brian.curtin/ubuntuone-client/820350-fix-readonly-readwrite
Only Brian Curtin can upload to this branch. If you are Brian Curtin please log in for upload directions.

Branch merges

Related bugs

Related blueprints

Branch information

Owner:
Brian Curtin
Project:
Ubuntu One Client
Status:
Development

Recent revisions

1190. By Brian Curtin on 2012-02-10

Add None values in the third positions for groups passed to _set_file_attributes

1189. By Brian Curtin on 2012-02-07

Tag issue 820350 with this branch.

1188. By Brian Curtin on 2012-02-07

If the extended API isn't needed, don't use it.

1187. By Brian Curtin on 2012-02-07

Adjust set_dir_readonly and set_dir_readwrite to properly function.

*readonly needs to not only set GENERIC_READ access for users but also
needs to keep the proper previous access intact for the administrator
and system groups.

The same is true of *readwrite except in that it needs to be careful
to not give back too much access. The USER_SID remains at GENERIC_READ
but needs to re-acquire DELETE access (leave that off and try deleting
the folder, it won't work). AUTH_USERS at this point will re-gain the
GENERIC_WRITE access. At this point, the folder should be back to normal -
deletable and writeable.

Most testing of this was done by comparing the results of "cacls <path>"
before and after going through a creation/readonly/readwrite cycle.
The results are not exact, but I've found no way to actually get before
and after to match. Someone speculated that cacls is using shorthand in
it's simple one-letter display. By definition, though, I think we have a
pretty solid match of the access being granted.

1186. By dobey on 2012-02-06

Remove the old, broken, and unused sdreactor code
Try the new gireactor first, and fall back to the old glib2reactor, when running scripts
Update code and tests to work correctly under either glib2reactor or gireactor

1185. By Facundo Batista on 2012-02-01

Two small memory improvements, "unblocked cancels" and "better deferred usage in PLT".

1184. By Diego Sarmentero on 2012-01-26

Fixed: Problem trying to create an udf with unicode username (LP: #921703 ).

1183. By Natalia Bidart on 2012-01-25

- Skip NotificationTestCase tests (LP: #921574).

1182. By Diego Sarmentero on 2012-01-25

- Fixed: tests are now not modifying the real user home (LP: #915380).

1181. By Manuel de la Peña on 2012-01-19

Adds the possibility to skip the lint checks on windows when passing the /skip-lint parameter to run-tests.bat.

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
Stacked on:
lp:ubuntuone-client
This branch contains Public information 
Everyone can see this information.

Subscribers