Merge lp:~brian-murray/ubuntu-release-upgrader/bug-1225016 into lp:ubuntu-release-upgrader

Proposed by Brian Murray
Status: Merged
Merge reported by: Steve Langasek
Merged at revision: not available
Proposed branch: lp:~brian-murray/ubuntu-release-upgrader/bug-1225016
Merge into: lp:ubuntu-release-upgrader
Diff against target: 51 lines (+8/-6)
3 files modified
DistUpgrade/DistUpgradeCache.py (+5/-5)
data/DistUpgrade.cfg (+1/-1)
data/removal_blacklist.cfg (+2/-0)
To merge this branch: bzr merge lp:~brian-murray/ubuntu-release-upgrader/bug-1225016
Reviewer Review Type Date Requested Status
Steve Langasek Pending
Review via email: mp+185671@code.launchpad.net

Description of the change

I've modified the release upgrader to ensure that the metapackage information is in sync, but thought it could use a second pair of eyes.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'DistUpgrade/DistUpgradeCache.py'
2--- DistUpgrade/DistUpgradeCache.py 2013-09-12 16:16:49 +0000
3+++ DistUpgrade/DistUpgradeCache.py 2013-09-15 14:29:21 +0000
4@@ -866,16 +866,16 @@
5 break
6 # check if we actually found one
7 if not metaPkgInstalled():
8- # FIXME: provide a list
9+ meta_pkgs = ', '.join(metapkgs[0:-1])
10 view.error(_("Can't guess meta-package"),
11 _("Your system does not contain a "
12- "ubuntu-desktop, kubuntu-desktop, xubuntu-desktop or "
13- "edubuntu-desktop package and it was not "
14+ "%s or %s package and it was not "
15 "possible to detect which version of "
16- "Ubuntu you are running.\n "
17+ "Ubuntu you are running.\n "
18 "Please install one of the packages "
19 "above first using synaptic or "
20- "apt-get before proceeding."))
21+ "apt-get before proceeding.") %
22+ (meta_pkgs, metapkgs[-1]))
23 return False
24 return True
25
26
27=== modified file 'data/DistUpgrade.cfg'
28--- data/DistUpgrade.cfg 2013-04-30 18:17:22 +0000
29+++ data/DistUpgrade.cfg 2013-09-15 14:29:21 +0000
30@@ -10,7 +10,7 @@
31 # Distro contains global information about the upgrade
32 [Distro]
33 # the meta-pkgs we support
34-MetaPkgs=ubuntu-desktop, kubuntu-desktop, xubuntu-desktop, ubuntustudio-desktop, ichthux-desktop, mythbuntu-desktop, ubuntu-netbook, kubuntu-netbook, lubuntu-desktop
35+MetaPkgs=ubuntu-desktop, kubuntu-desktop, xubuntu-desktop, ubuntustudio-desktop, mythbuntu-desktop, kubuntu-netbook, lubuntu-desktop
36 BaseMetaPkgs=ubuntu-minimal, ubuntu-standard
37 Demotions=demoted.cfg
38 RemoveEssentialOk=sysvinit, sysvutils, belocs-locales-bin
39
40=== modified file 'data/removal_blacklist.cfg'
41--- data/removal_blacklist.cfg 2012-09-04 08:01:44 +0000
42+++ data/removal_blacklist.cfg 2013-09-15 14:29:21 +0000
43@@ -5,6 +5,8 @@
44 kubuntu-desktop
45 xubuntu-desktop
46 lubuntu-desktop
47+mythbuntu-desktop
48+ubuntustudio-desktop
49 # ubuntu-release-upgrader should not remove itself or update-manager
50 update-manager
51 update-manager-core

Subscribers

People subscribed via source and target branches