Code review comment for lp:~brian-murray/ubuntu-qa-tools/uvt-verbosity

Revision history for this message
Marc Deslauriers (mdeslaur) wrote :

Thanks for the merge proposal.

I'm going to simply switch to 'generic' instead of 'ubuntu$release_num' as that will prevent us from running on earlier releases, or running newer versions of Ubuntu if they haven't yet been added to libosinfo.

We're overriding the disk and net options in our virt-install command anyway, so specifying the exact ubuntu version doesn't gain us anything.

I'll also add the verbose fix.

Thanks!

review: Disapprove

« Back to merge proposal