Merge lp:~brian-murray/ubuntu-archive-tools/time-to-release into lp:ubuntu-archive-tools

Proposed by Brian Murray
Status: Merged
Merged at revision: 1184
Proposed branch: lp:~brian-murray/ubuntu-archive-tools/time-to-release
Merge into: lp:ubuntu-archive-tools
Diff against target: 14 lines (+5/-1)
1 file modified
sru_workflow.py (+5/-1)
To merge this branch: bzr merge lp:~brian-murray/ubuntu-archive-tools/time-to-release
Reviewer Review Type Date Requested Status
Steve Langasek Needs Fixing
Simon Quigley (community) Approve
Review via email: mp+348100@code.launchpad.net

Description of the change

This is in response to comments #120+ in https://bugs.launchpad.net/ubuntu/+source/gdm3/+bug/1766137. People were pretty anxious to see the fix, understandably so, and maybe this'll help people understand the process better. I decided not to update the wiki page because it seems unlikely that people will click on links.

To post a comment you must log in.
Revision history for this message
Simon Quigley (tsimonq2) wrote :

I want to bikeshed the new wording a bit so it flows right...

"can take" and "at least" seem to be conflicting a bit, at least to me. We're saying that it typically takes 7 days, when my understanding has always been that this is the rule, although exceptions can be made. Then we say that it takes "at least" 7 days, meaning that it can take more even if the verification is done. On first glance, it seems like it's fine, but SRUs aren't accepted on weekends, right? There are some cases where a package is accepted into -proposed and a week from that is a holiday for some, but I'd still call that unordinary.

review: Needs Fixing
1177. By Brian Murray

improve timeline based on reviewer feedback

Revision history for this message
Simon Quigley (tsimonq2) wrote :

Thanks!

review: Approve
Revision history for this message
Steve Langasek (vorlon) :
review: Needs Fixing
1178. By Brian Murray

Grammar changes for slangasek.

1179. By Brian Murray

merge with upstream

Revision history for this message
Brian Murray (brian-murray) wrote :

I've reworded the N.B. message.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'sru_workflow.py'
2--- sru_workflow.py 2018-08-10 21:57:11 +0000
3+++ sru_workflow.py 2018-08-31 23:15:42 +0000
4@@ -132,5 +132,9 @@
5 'be able to proceed.\n\nFurther information regarding the '
6 'verification process can be found at '
7 'https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . '
8- 'Thank you in advance!' % (release, release, release))
9+ 'Thank you in advance for helping!\n\n'
10+ 'N.B. The updated package will be released to -updates after '
11+ 'the bug(s) fixed by this package have been verified and '
12+ 'the package has been in -proposed for a minimum of 7 days.' %
13+ (release, release, release))
14 bug.newMessage(content=text, subject='Please test proposed package')

Subscribers

People subscribed via source and target branches