Merge lp:~brian-murray/ubuntu-archive-tools/stop-phasing into lp:ubuntu-archive-tools

[Brian Murray]

The phased updater only respects phasing set to 0% if there is a regression or rate increase in the Error Tracker, work around that by hard coding packages that shouldn't be phased.

[Łukasz Zemczak (sil2100)]

I think for now this would work.

But after we land this I would like us to consider two options:
 1) Making the STOPPED_PACKAGES list work per versions, so the packagelist being ['glibc/SOMEVERSION'] etc.
 2) Maybe moving this to a separate file? Like, some exceptions file hosted elsewhere like with the phase exceptions for resetting regressions?

review: Approve

=== modified file 'phased-updater'
--- phased-updater	2020-09-10 10:32:02 +0000
+++ phased-updater	2020-11-04 17:01:44 +0000
@@ -650,13 +650,16 @@
                 last_pup = None
             max_pup = 0
             if last_pup == 0:
-                    for allpb in archive.getPublishedBinaries(
-                            exact_match=True, pocket='Updates',
-                            binary_name=pbs[0].binary_package_name):
-                        if allpb.distro_arch_series.distroseries == release:
-                            if allpb.phased_update_percentage > 0:
-                                max_pup = allpb.phased_update_percentage
-                                break
+                if rname in STOPPED_PACKAGES:
+                    if src_pkg in STOPPED_PACKAGES[rname]:
+                        continue
+                for allpb in archive.getPublishedBinaries(
+                        exact_match=True, pocket='Updates',
+                        binary_name=pbs[0].binary_package_name):
+                    if allpb.distro_arch_series.distroseries == release:
+                        if allpb.phased_update_percentage > 0:
+                            max_pup = allpb.phased_update_percentage
+                            break
             if max_pup and last_pup == 0:
                 rate_increase = crash_rate_increase(release, src_pkg, version, max_pup)
             else:
@@ -734,6 +737,7 @@
     EMAIL_SENDER = '[e-mail]'
     PUP_INCREMENT = 10
     SLOW_PACKAGES = {'secureboot-db'}
+    STOPPED_PACKAGES = {'bionic': ['glibc']}
     PUP_SLOW_INCREMENT = 1
     REPORT_FILE = 'phased-updates.html'
     parser = OptionParser(usage="usage: %prog [options]")