Merge lp:~brian-murray/ubuntu-archive-tools/sru-review-queues into lp:ubuntu-archive-tools

Proposed by Brian Murray
Status: Merged
Merged at revision: 824
Proposed branch: lp:~brian-murray/ubuntu-archive-tools/sru-review-queues
Merge into: lp:ubuntu-archive-tools
Diff against target: 31 lines (+5/-3)
1 file modified
sru-review (+5/-3)
To merge this branch: bzr merge lp:~brian-murray/ubuntu-archive-tools/sru-review-queues
Reviewer Review Type Date Requested Status
Ubuntu Package Archive Administrators Pending
Review via email: mp+215920@code.launchpad.net

Description of the change

arges was trying to review a debdiff in the New queue with sru-review and it failed. This fixes that failure.

To post a comment you must log in.
824. By Brian Murray

restore empty line

825. By Brian Murray

merge with upstream

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'sru-review'
2--- sru-review 2014-02-24 17:57:37 +0000
3+++ sru-review 2014-04-15 18:50:03 +0000
4@@ -104,6 +104,10 @@
5
6 Return (package_upload, debdiff URL) pair.
7 '''
8+ queues = {'New': 0, 'Unapproved': 1, 'Rejected': 4}
9+ queue_url = ('https://launchpad.net/ubuntu/%s/+queue?'
10+ 'queue_state=%s&batch=300' %
11+ (series.name, queues[queue]))
12 uploads = [upload for upload in
13 series.getPackageUploads(archive=archive, exact_match=True,
14 name=sourcepkg, pocket='Proposed',
15@@ -124,7 +128,7 @@
16 '\d+/%s_[^"_]+_[^_"]+\.diff\.gz)">\s*diff from' %
17 re.escape(quote(sourcepkg)))
18
19- queue_html = urlopen(queue_url % series.name).read()
20+ queue_html = urlopen(queue_url).read()
21
22 m = oops_re.search(queue_html)
23 if m:
24@@ -280,8 +284,6 @@
25 if __name__ == '__main__':
26
27 default_release = 'saucy'
28- queue_url = ('https://launchpad.net/ubuntu/%s/+queue?'
29- 'queue_state=1&batch=300')
30 ppa_url = ('https://launchpad.net/~%s/+archive/%s/+packages?'
31 'field.series_filter=%s')
32

Subscribers

People subscribed via source and target branches