Merge lp:~brian-murray/ubuntu-archive-tools/sru-review-bug-check into lp:ubuntu-archive-tools

Proposed by Brian Murray on 2015-05-07
Status: Merged
Merged at revision: 960
Proposed branch: lp:~brian-murray/ubuntu-archive-tools/sru-review-bug-check
Merge into: lp:ubuntu-archive-tools
Diff against target: 30 lines (+13/-0)
1 file modified
sru-review (+13/-0)
To merge this branch: bzr merge lp:~brian-murray/ubuntu-archive-tools/sru-review-bug-check
Reviewer Review Type Date Requested Status
Ubuntu Package Archive Administrators 2015-05-07 Pending
Review via email: mp+258563@code.launchpad.net

Description of the Change

Let's try and avoiding having SRUs without a bug reference see LP: #1444436.

To post a comment you must log in.
Brian Murray (brian-murray) wrote :

This wouldn't have produced any Launchpad-Bugs-Fixed:

xserver-xorg-video-intel (2:2.99.914-1~exp1ubuntu4.3) utopic; urgency=medium

  * bdw-annotate-more-64bit-pointer-locations.diff
    bdw-clamp-urb-allocations-for-gt3.diff:
    Fix BDW GT3. (#1444436)

961. By Brian Murray on 2015-05-07

sru-review: remove continue and exit on N

962. By Brian Murray on 2015-05-08

sru-review: Also remind after viewing the debdiff that there are no Launchpad bugs.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'sru-review'
2--- sru-review 2015-05-05 01:52:51 +0000
3+++ sru-review 2015-05-08 19:23:20 +0000
4@@ -378,6 +378,17 @@
5 # to view the diff
6 changes = parse_changes(changes_url)
7
8+ changelog_bugs = True
9+ if not changes['bugs']:
10+ changelog_bugs = False
11+ print('There are no Launchpad bugs in the changelog!',
12+ file=sys.stderr)
13+ print('''View the debdiff anyway? [yN]''', end="")
14+ response = sys.stdin.readline()
15+ if response.strip().lower().startswith('n'):
16+ print('''Exiting''')
17+ sys.exit(1)
18+
19 if opts.browser and changes['bugs']:
20 for b in changes['bugs']:
21 # use a full url so the right task is highlighted
22@@ -403,6 +414,8 @@
23 file=sys.stderr)
24 sys.exit(0)
25
26+ if not changelog_bugs:
27+ print("The SRU has no Launchpad bugs referenced!\n")
28 print("Accept the package into -proposed? [yN] ", end="")
29 response = sys.stdin.readline()
30 if response.strip().lower().startswith('y'):

Subscribers

People subscribed via source and target branches