Merge lp:~brian-murray/ubuntu-archive-tools/sru-report-incomplete into lp:ubuntu-archive-tools

Proposed by Brian Murray
Status: Merged
Merged at revision: 1193
Proposed branch: lp:~brian-murray/ubuntu-archive-tools/sru-report-incomplete
Merge into: lp:ubuntu-archive-tools
Diff against target: 50 lines (+14/-1)
1 file modified
sru-report (+14/-1)
To merge this branch: bzr merge lp:~brian-murray/ubuntu-archive-tools/sru-report-incomplete
Reviewer Review Type Date Requested Status
Łukasz Zemczak Approve
Review via email: mp+358673@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Generally +1, just two inline things.

review: Needs Fixing
1193. By Brian Murray

better check the package and release for a task, only check tasks when we have a bug

1194. By Brian Murray

add in the yellow color to the legend

Revision history for this message
Brian Murray (brian-murray) wrote :

I'm now splitting task_link with / to address the package naming concern. I also put the task look up into the try / except for the Launchpad bug.

Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Ok, thanks! This is better now. The splitting and analysis of self_link is not the most pretty way to go, but I guess it should work fine. Approving.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'sru-report'
2--- sru-report 2018-07-20 18:29:04 +0000
3+++ sru-report 2018-11-21 19:00:41 +0000
4@@ -185,6 +185,7 @@
5 .noborder { border-style: none; }
6 a { color: blue; }
7 a.messages { color: #999900; font-weight: bold; }
8+ a.incomplete { color: yellow; font-weight: bold; }
9 a.verified { color: green; font-weight: bold; }
10 a.verificationfailed { color: red; font-weight: bold; }
11 a.kerneltracking { font-style: italic; }
12@@ -220,6 +221,7 @@
13
14 <p>Bugs in <span style="color:green;">green</span> are verified,
15 bugs in <span style="color:red;">red</span> failed verification,
16+bugs in <span style="color:yellow;">yellow</span> are Incomplete,
17 bugs in <span style="color: #999900;">golden</span> have received a comment
18 since the package was accepted in -proposed,
19 bugs in <span style="color: gray;">gray</span> are candidates for removal
20@@ -331,10 +333,19 @@
21 antique = False
22 for b, t in sorted(rpkg['bugs'].iteritems()):
23 cls = ' class="'
24+ incomplete = False
25 try:
26 bug = lp.bugs[b]
27 bug_title = bug.title.encode('UTF-8')
28 hover_text = bug_title
29+ for task in bug.bug_tasks:
30+ if task.self_link.split('/')[4] != 'ubuntu':
31+ continue
32+ if pkg == task.self_link.split('/')[7] \
33+ and release == task.self_link.split('/')[5]:
34+ if task.status == 'Incomplete':
35+ incomplete = True
36+ break
37 except KeyError:
38 logging.debug(
39 'bug %d does not exist or is not accessible' % b)
40@@ -343,7 +354,9 @@
41 if ('kernel-tracking-bug' in t or
42 'kernel-release-tracking-bug' in t):
43 cls += 'kerneltracking '
44- if ('verification-failed' in t or
45+ if incomplete:
46+ cls += ' incomplete'
47+ elif ('verification-failed' in t or
48 'verification-failed-%s' % release in t):
49 cls += ' verificationfailed'
50 elif 'verification-done-%s' % release in t:

Subscribers

People subscribed via source and target branches