Merge lp:~brian-murray/ubuntu-archive-tools/sru-notification-casper into lp:ubuntu-archive-tools

Proposed by Brian Murray
Status: Merged
Merged at revision: 1062
Proposed branch: lp:~brian-murray/ubuntu-archive-tools/sru-notification-casper
Merge into: lp:ubuntu-archive-tools
Diff against target: 64 lines (+21/-16)
1 file modified
sru-review (+21/-16)
To merge this branch: bzr merge lp:~brian-murray/ubuntu-archive-tools/sru-notification-casper
Reviewer Review Type Date Requested Status
Ubuntu Package Archive Administrators Pending
Review via email: mp+309711@code.launchpad.net

Description of the change

Instead of spreading FUD[1] about how to test an SRU of casper, let's use a comment that says to test the latest daily Live CD.

[1] https://bugs.launchpad.net/ubuntu/+source/casper/+bug/1619188/comments/79

Also switch the default release to yakkety and stop looking up the package_name when we already know it.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'sru-review'
2--- sru-review 2016-10-07 21:38:16 +0000
3+++ sru-review 2016-10-31 22:05:32 +0000
4@@ -319,19 +319,24 @@
5 'a few hours in the -proposed repository.\n\n' % (
6 release))
7
8- text += ('Please help us by testing this new package. See '
9- 'https://wiki.ubuntu.com/Testing/EnableProposed for '
10- 'documentation how to enable and use -proposed. Your feedback '
11- 'will aid us getting this update out to other Ubuntu users.\n\n'
12- 'If this package fixes the bug for you, please add a comment to '
13- 'this bug, mentioning the version of the package you tested, and '
14- 'change the tag from verification-needed to verification-done. '
15- 'If it does not fix the bug for you, please add a comment '
16- 'stating that, and change the tag to verification-failed. In '
17- 'either case, details of your testing will help us make a better '
18- 'decision.\n\n'
19- 'Further information regarding the verification process can be '
20- 'found at '
21+ text += ('Please help us by testing this new package. ')
22+
23+ if sourcepkg == 'casper':
24+ text += ('To properly test it you will need to obtain and boot '
25+ 'a daily build of a Live CD for %s.' % (release))
26+ else:
27+ text += ('See https://wiki.ubuntu.com/Testing/EnableProposed for '
28+ 'documentation on how to enable and use -proposed.')
29+
30+ text += ('Your feedback will aid us getting this update out to other '
31+ 'Ubuntu users.\n\nIf this package fixes the bug for you, '
32+ 'please add a comment to this bug, mentioning the version of the '
33+ 'package you tested, and change the tag from verification-needed '
34+ 'to verification-done. If it does not fix the bug for you, '
35+ 'please add a comment stating that, and change the tag to '
36+ 'verification-failed. In either case, details of your testing '
37+ 'will help us make a better decision.\n\nFurther information '
38+ 'regarding the verification process can be found at '
39 'https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . '
40 'Thank you in advance!')
41 bug.newMessage(content=text, subject='Please test proposed package')
42@@ -339,7 +344,7 @@
43
44 if __name__ == '__main__':
45
46- default_release = 'xenial'
47+ default_release = 'yakkety'
48 ppa_url = ('https://launchpad.net/~%s/+archive/ubuntu/%s/+packages?'
49 'field.series_filter=%s')
50
51@@ -416,11 +421,11 @@
52 for b in changes['bugs']:
53 # use a full url so the right task is highlighted
54 webbrowser.open('https://bugs.launchpad.net/ubuntu/+source/'
55- '%s/+bug/%s' % (upload.package_name, b))
56+ '%s/+bug/%s' % (sourcepkg, b))
57 # also open the source package page to review version numbers
58 if opts.browser:
59 webbrowser.open('https://launchpad.net/ubuntu/+source/'
60- '%s' % (upload.package_name))
61+ '%s' % (sourcepkg))
62
63 if debdiff and opts.view:
64 tfile = tempfile.mkstemp()

Subscribers

People subscribed via source and target branches