Merge lp:~brian-murray/ubuntu-archive-tools/record-signer_name into lp:ubuntu-archive-tools

Proposed by Brian Murray
Status: Merged
Merged at revision: 905
Proposed branch: lp:~brian-murray/ubuntu-archive-tools/record-signer_name
Merge into: lp:ubuntu-archive-tools
Diff against target: 12 lines (+1/-1)
1 file modified
phased-updater (+1/-1)
To merge this branch: bzr merge lp:~brian-murray/ubuntu-archive-tools/record-signer_name
Reviewer Review Type Date Requested Status
Colin Watson Approve
Review via email: mp+239434@code.launchpad.net

Description of the change

We've emailed a developer more than one time because we had to look up their email address in the changelog which sets signer_name to something different than signer.name. We check for signer_name in the file that contains information about who we've notified, but we end up writing signer.name. This branch fixes that.

Here's the information recorded in the notificatons file indicating we've contacted them multiple times.

bluesabre, https://errors.ubuntu.com/problem/1e41079cc8067ce3ca006da5fe721a63341b0975, mugshot, 0.2.5-0ubuntu0.1
...
bluesabre, https://errors.ubuntu.com/problem/1e41079cc8067ce3ca006da5fe721a63341b0975, mugshot, 0.2.5-0ubuntu0.1

To post a comment you must log in.
Revision history for this message
Colin Watson (cjwatson) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'phased-updater'
2--- phased-updater 2014-09-04 20:27:04 +0000
3+++ phased-updater 2014-10-23 18:11:21 +0000
4@@ -308,7 +308,7 @@
5 # add signer, problem, pkg, version to notifications csv file
6 with open(NOTIFICATIONS, 'a') as notify_file:
7 for bucket in spph_buckets[rname][spph]['buckets']:
8- notify_file.write('%s, %s, %s, %s\n' % (signer.name,
9+ notify_file.write('%s, %s, %s, %s\n' % (signer_name,
10 bucket, pkg, version))
11 if 'rate' in spph_buckets[rname][spph]:
12 # see if they have been emailed about the increased rate

Subscribers

People subscribed via source and target branches