Merge lp:~brian-murray/ubuntu-archive-tools/queue-casing into lp:ubuntu-archive-tools

Proposed by Brian Murray
Status: Merged
Merged at revision: 1071
Proposed branch: lp:~brian-murray/ubuntu-archive-tools/queue-casing
Merge into: lp:ubuntu-archive-tools
Diff against target: 30 lines (+5/-3)
1 file modified
sru-review (+5/-3)
To merge this branch: bzr merge lp:~brian-murray/ubuntu-archive-tools/queue-casing
Reviewer Review Type Date Requested Status
Ubuntu Package Archive Administrators Pending
Review via email: mp+313052@code.launchpad.net

Description of the change

Having to use Rejected instead of rejected is kind of lame.

To post a comment you must log in.
1071. By Brian Murray

sru-review: fix a typo

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'sru-review'
2--- sru-review 2016-12-02 00:07:55 +0000
3+++ sru-review 2016-12-12 19:01:13 +0000
4@@ -84,7 +84,8 @@
5 "-q", "--queue", dest='queue',
6 help='Use a specific queue instead of Unapproved',
7 default="Unapproved",
8- choices=("Unapproved", "New", "Rejected"),
9+ choices=("Unapproved", "New", "Rejected",
10+ "unapproved", "new", "rejected"),
11 metavar='QUEUE')
12
13 (opts, args) = parser.parse_args()
14@@ -118,13 +119,14 @@
15 Return (package_upload, changes URL, debdiff URL) tuple.
16 '''
17 queues = {'New': 0, 'Unapproved': 1, 'Rejected': 4}
18+ queue = options.queue.title()
19 queue_url = ('https://launchpad.net/ubuntu/%s/+queue?'
20 'queue_state=%s&batch=300' %
21- (series.name, queues[options.queue]))
22+ (series.name, queues[queue]))
23 uploads = [upload for upload in
24 series.getPackageUploads(archive=archive, exact_match=True,
25 name=sourcepkg, pocket='Proposed',
26- status=options.queue, version=version)]
27+ status=queue, version=version)]
28 if len(uploads) == 0:
29 print('ERROR: Queue does not have an upload of this source.',
30 file=sys.stderr)

Subscribers

People subscribed via source and target branches