Merge lp:~brian-murray/ubuntu-archive-tools/phased-updater-version-in-url into lp:ubuntu-archive-tools

Proposed by Brian Murray
Status: Merged
Merged at revision: 837
Proposed branch: lp:~brian-murray/ubuntu-archive-tools/phased-updater-version-in-url
Merge into: lp:ubuntu-archive-tools
Diff against target: 32 lines (+6/-3)
1 file modified
phased-updater (+6/-3)
To merge this branch: bzr merge lp:~brian-murray/ubuntu-archive-tools/phased-updater-version-in-url
Reviewer Review Type Date Requested Status
Ubuntu Package Archive Administrators Pending
Review via email: mp+222891@code.launchpad.net

Description of the change

I updated daisy to return the package version in the web_link data provided in the json file, so the phased-updater doesn't need to add it.

Also I fixed a crash where previous amount was None.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'phased-updater'
2--- phased-updater 2014-04-18 21:02:58 +0000
3+++ phased-updater 2014-06-12 00:07:22 +0000
4@@ -18,7 +18,7 @@
5 '''Increment the Phased-Update-Percentage for a package
6
7 Check to see whether or not there is a regression (new crash bucket or
8-increase rate of errors about a package) using errors.ubuntu.com and if
9+increase in rate of errors about a package) using errors.ubuntu.com and if
10 not increment the Phased-Update-Percentage for the package.
11 Additionally, generate an html report regarding state of phasing of
12 packages and email uploaders regarding issues with their uploads.
13@@ -442,6 +442,7 @@
14 if not previous_amount:
15 logging.info('No previous crash data found for %s %s' %
16 (src_pkg, pvers))
17+ previous_amount = 0
18 if 'difference' in data:
19 increase = data['difference']
20 elif 'this_count' in data:
21@@ -453,8 +454,10 @@
22 logging.info('[%s/%s] increase: %s, previous_avg: %s' %
23 (release_name.replace('Ubuntu ', ''), src_pkg,
24 increase, previous_amount))
25- # 2013-06-20 - Fix errors api to add this
26- link = data['web_link'] + '&version=%s' % version
27+ if '&version=' not in data['web_link']:
28+ link = data['web_link'] + '&version=%s' % version
29+ else:
30+ link = data['web_link']
31 logging.info('Details (rate increase): %s' % link)
32 return(increase, link)
33

Subscribers

People subscribed via source and target branches