Merge lp:~brian-murray/ubuntu-archive-tools/checkrdepends-py3 into lp:ubuntu-archive-tools

Proposed by Brian Murray
Status: Merged
Merged at revision: 1384
Proposed branch: lp:~brian-murray/ubuntu-archive-tools/checkrdepends-py3
Merge into: lp:ubuntu-archive-tools
Diff against target: 55 lines (+4/-7)
3 files modified
checkrdepends (+1/-3)
move-milestoned-bugs (+1/-1)
permissions-report (+2/-3)
To merge this branch: bzr merge lp:~brian-murray/ubuntu-archive-tools/checkrdepends-py3
Reviewer Review Type Date Requested Status
Iain Lane Approve
Review via email: mp+390595@code.launchpad.net

Description of the change

Migrate move-milestoned-bugs, permissions-report, and checkrdepends to python3. I tested all of them without issue although I didn't actually move any milestoned bugs but the move is python3 safe.

To post a comment you must log in.
Revision history for this message
Iain Lane (laney) wrote :

cheers

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'checkrdepends'
2--- checkrdepends 2020-04-24 15:35:59 +0000
3+++ checkrdepends 2020-09-11 03:21:51 +0000
4@@ -1,4 +1,4 @@
5-#! /usr/bin/python2.7
6+#! /usr/bin/python3
7
8 # Copyright (C) 2009, 2010, 2011, 2012 Canonical Ltd.
9
10@@ -14,8 +14,6 @@
11 # You should have received a copy of the GNU General Public License
12 # along with this program. If not, see <http://www.gnu.org/licenses/>.
13
14-from __future__ import print_function
15-
16 from collections import defaultdict
17 import optparse
18 import os
19
20=== modified file 'move-milestoned-bugs'
21--- move-milestoned-bugs 2020-01-25 02:19:13 +0000
22+++ move-milestoned-bugs 2020-09-11 03:21:51 +0000
23@@ -1,4 +1,4 @@
24-#!/usr/bin/python2.7
25+#!/usr/bin/python3
26
27 # Copyright (C) 2011, 2012 Canonical Ltd.
28 # Author: Martin Pitt <martin.pitt@ubuntu.com>
29
30=== modified file 'permissions-report'
31--- permissions-report 2020-01-25 02:19:13 +0000
32+++ permissions-report 2020-09-11 03:21:51 +0000
33@@ -1,4 +1,4 @@
34-#!/usr/bin/python2.7
35+#!/usr/bin/python3
36 # -*- coding: utf-8 -*-
37
38 # Copyright (C) 2013 Canonical Ltd.
39@@ -16,7 +16,6 @@
40 # You should have received a copy of the GNU General Public License
41 # along with this program. If not, see <http://www.gnu.org/licenses/>.
42
43-from __future__ import print_function
44 from launchpadlib.launchpad import Launchpad
45
46 import argparse
47@@ -81,7 +80,7 @@
48 ubuntudev += ["ubuntu-backporters", "ubuntu-security", "ubuntu-archive",
49 "ubuntu-release", "ubuntu-sru"]
50
51-for target, people in entries.items():
52+for target, people in list(entries.items()):
53 with open(os.path.join(args.target, target), "w+") as fd:
54 for user, permissions in sorted(people.items()):
55 fd.write("=== %s ===\n" % user)

Subscribers

People subscribed via source and target branches