Merge lp:~brian-murray/ubuntu-archive-tools/change-purple into lp:ubuntu-archive-tools

Proposed by Brian Murray
Status: Merged
Merged at revision: 1092
Proposed branch: lp:~brian-murray/ubuntu-archive-tools/change-purple
Merge into: lp:ubuntu-archive-tools
Diff against target: 44 lines (+2/-10)
1 file modified
sru-report (+2/-10)
To merge this branch: bzr merge lp:~brian-murray/ubuntu-archive-tools/change-purple
Reviewer Review Type Date Requested Status
Steve Langasek Needs Information
Review via email: mp+322783@code.launchpad.net

Description of the change

07:57 < slangasek> bdmurray: should the pending-sru report maybe
                   show a bug as green instead of purple when it's
                   verified for *this* series that we're currently
                   looking at?
07:59 < bdmurray> slangasek: because now if its purple you won't
                  look at the bug, but if it's green you would?
08:01 < slangasek> bdmurray: if I have a mix of green and purple I
                   have to look at the bug to see if it's fixed for
                   this release; if it's all green I know it should
                   be ready to release and can just load up all the
                   bugs for one final check
08:03 < bdmurray> slangasek: ack, so it'd help with multi-bug SRUs.
08:04 < slangasek> bdmurray: imho yes

To post a comment you must log in.
Revision history for this message
Steve Langasek (vorlon) wrote :

I'm confused by the changes to both the text and the code. See comments inline.

review: Needs Information
Revision history for this message
Brian Murray (brian-murray) wrote :

I've inline replied to your inline comment.

1093. By Brian Murray

drop the verification partial logic, also the # in front of the bug number serves no purpose.

Revision history for this message
Brian Murray (brian-murray) wrote :

I've dropped the verification partial classification. I also removed the # from in front of the bug number because it seems silly.

1094. By Brian Murray

finish removing the purple refernce

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'sru-report'
2--- sru-report 2017-04-13 22:17:50 +0000
3+++ sru-report 2017-04-19 20:57:10 +0000
4@@ -186,7 +186,6 @@
5 a.messages { color: #999900; font-weight: bold; }
6 a.verified { color: green; font-weight: bold; }
7 a.verificationfailed { color: red; font-weight: bold; }
8- a.verificationpartial { color: #660099; font-weight: bold; }
9 a.kerneltracking { font-style: italic; }
10 a.testing { color: blue; }
11 a.broken { text-decoration: line-through; color: black; }
12@@ -218,10 +217,8 @@
13 href="http://people.canonical.com/~ubuntu-archive/phased-updates.html">
14 report</a>.</p>
15
16-<p>Bugs in <span style="color:green;">green</span> are verified by QA,
17+<p>Bugs in <span style="color:green;">green</span> are verified,
18 bugs in <span style="color:red;">red</span> failed verification,
19-bugs in <span style="color:#660099;">purple</span> are verified for a task
20-but need verification for another task,
21 bugs in <span style="color: #999900;">golden</span> have received a comment
22 since the package was accepted in -proposed,
23 bugs in <span style="color: gray;">gray</span> are candidates for removal
24@@ -338,11 +335,6 @@
25 cls += 'kerneltracking '
26 if 'verification-failed' in t:
27 cls += ' verificationfailed'
28- elif (('verification-done' in t or
29- 'verification-done-%s' % release in t) and
30- 'verification-needed' in t):
31- cls += ' verificationpartial'
32- removable = False
33 elif ('verification-done' in t or
34 'verification-done-%s' % release in t):
35 cls += ' verified'
36@@ -395,7 +387,7 @@
37 cls += '"'
38
39 print('<a href="%s/bugs/%d" '
40- 'title="%s" %s>#%d%s</a>' %
41+ 'title="%s" %s>%d%s</a>' %
42 (lp_url, b, hover_text.replace('"', ''), cls, b,
43 '(hw)' if 'hw-specific' in t else ''))
44 if antique and removable:

Subscribers

People subscribed via source and target branches