Merge lp:~brian-murray/software-properties/bug-1506169 into lp:software-properties

Proposed by Brian Murray
Status: Merged
Merged at revision: 947
Proposed branch: lp:~brian-murray/software-properties/bug-1506169
Merge into: lp:software-properties
Diff against target: 28 lines (+10/-1)
2 files modified
debian/changelog (+7/-0)
softwareproperties/gtk/SoftwarePropertiesGtk.py (+3/-1)
To merge this branch: bzr merge lp:~brian-murray/software-properties/bug-1506169
Reviewer Review Type Date Requested Status
Michael Vogt (community) Approve
Review via email: mp+275560@code.launchpad.net

Description of the change

This will fix an issue where linux-generic is getting uninstalled if it is already installed when one switches to a proprietary driver that requires dkms.

To post a comment you must log in.
Revision history for this message
Michael Vogt (mvo) wrote :

Looks good, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2015-10-13 18:31:21 +0000
3+++ debian/changelog 2015-10-23 18:04:17 +0000
4@@ -1,3 +1,10 @@
5+software-properties (0.96.14) UNRELEASED; urgency=medium
6+
7+ * If a driver package depends on dkms and the correct linux meta package is
8+ already installed don't uninstall it. (LP: #1506169)
9+
10+ -- Brian Murray <brian@ubuntu.com> Fri, 23 Oct 2015 10:58:33 -0700
11+
12 software-properties (0.96.13) wily; urgency=medium
13
14 * Properly parse a ppa which has a leading slash, something which a lot of
15
16=== modified file 'softwareproperties/gtk/SoftwarePropertiesGtk.py'
17--- softwareproperties/gtk/SoftwarePropertiesGtk.py 2014-12-01 07:05:24 +0000
18+++ softwareproperties/gtk/SoftwarePropertiesGtk.py 2015-10-23 18:04:17 +0000
19@@ -1176,7 +1176,9 @@
20 if (linux_meta and
21 linux_meta not in self.driver_changes):
22 # Install the linux metapackage
23- self.driver_changes.append(self.apt_cache[linux_meta])
24+ lmp = self.apt_cache[linux_meta]
25+ if not lmp.is_installed:
26+ self.driver_changes.append(lmp)
27 except KeyError:
28 pass
29

Subscribers

People subscribed via source and target branches

to status/vote changes: