Merge lp:~brian-murray/mago/gcalc-test-modulus into lp:~mago-contributors/mago/mago-1.0

Proposed by Brian Murray
Status: Merged
Merged at revision: 140
Proposed branch: lp:~brian-murray/mago/gcalc-test-modulus
Merge into: lp:~mago-contributors/mago/mago-1.0
Diff against target: 41 lines (+13/-1)
3 files modified
gcalctool/README (+2/-0)
gcalctool/gcalctool_calculations.xml (+9/-0)
mago/application/gcalc.py (+2/-1)
To merge this branch: bzr merge lp:~brian-murray/mago/gcalc-test-modulus
Reviewer Review Type Date Requested Status
Nagappan Alagappan Approve
Review via email: mp+40987@code.launchpad.net

Description of the change

I added in the modulusdivide button to gcalc and wrote a test for a Debian bug report. I'll be updating the testcases at qa.ubuntu.com shortly.

To post a comment you must log in.
Revision history for this message
Nagappan Alagappan (nagappan) wrote :

Looks okay to commit

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'gcalctool/README'
2--- gcalctool/README 2010-01-06 19:02:03 +0000
3+++ gcalctool/README 2010-11-16 17:46:55 +0000
4@@ -44,3 +44,5 @@
5 - 10-2=8
6 - 14/2=7
7 - 5*6=30
8+ - 7921 mod 14=11
9+ Verify that Debian bug 410763 is still fixed
10
11=== modified file 'gcalctool/gcalctool_calculations.xml'
12--- gcalctool/gcalctool_calculations.xml 2010-07-21 09:24:47 +0000
13+++ gcalctool/gcalctool_calculations.xml 2010-11-16 17:46:55 +0000
14@@ -58,4 +58,13 @@
15 <view>BASIC</view>
16 </args>
17 </case>
18+ <case name="7">
19+ <method>calculate</method>
20+ <description>modulus - debian bug 410763</description>
21+ <args>
22+ <input>7921m14=</input>
23+ <oracle>11</oracle>
24+ <view>ADVANCED</view>
25+ </args>
26+ </case>
27 </suite>
28
29=== modified file 'mago/application/gcalc.py'
30--- mago/application/gcalc.py 2010-10-20 10:17:11 +0000
31+++ mago/application/gcalc.py 2010-11-16 17:46:55 +0000
32@@ -59,7 +59,8 @@
33 "/" : "btndivide",
34 "C" : "btnclear",
35 "." : "btnnumeric_point",
36- "s" : "btnsquare_root"}
37+ "s" : "btnsquare_root",
38+ "m" : "btnmodulusdivide"}
39 EDITBAR_ROLE = "edit bar"
40 EDITBAR_INDEX = 0
41 SLEEP_DELAY = 2

Subscribers

People subscribed via source and target branches

to status/vote changes: