Merge lp:~brian-murray/launchpad/x-launchpad-bug-modifier-follow-on into lp:launchpad
Status: | Merged |
---|---|
Approved by: | Māris Fogels |
Approved revision: | no longer in the source branch. |
Merged at revision: | 11379 |
Proposed branch: | lp:~brian-murray/launchpad/x-launchpad-bug-modifier-follow-on |
Merge into: | lp:launchpad |
Diff against target: |
77 lines (+61/-1) 2 files modified
lib/lp/bugs/mail/tests/test_bug_task_modification.py (+60/-0) lib/lp/bugs/scripts/bugnotification.py (+1/-1) |
To merge this branch: | bzr merge lp:~brian-murray/launchpad/x-launchpad-bug-modifier-follow-on |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Māris Fogels (community) | Approve | ||
Review via email: mp+32900@code.launchpad.net |
Commit message
Add in X-Launchpad-
Description of the change
This branch is a follows up a merge proposal, https:/
I also added in a test, test_bug_
== Tests ==
bin/test -cvv -t bugnotification
Hi Brian,
These changes look good. I just had a few questions:
* On line 28 of the diff, there are brackets around ObjectModifiedE vent. I assume that is a left-over from earlier imports? nNotification should either be made more general, or the class name should be made more specific to match the docstring.
* The docstring for TestModificatio
* Is the sanity check for the stub mailer on line 50 of the diff necessary? I would hope the TestCase object reliably cleans up the stub mailer for you.
I think the branch looks good. r=mars with the tweaks I listed above.
Maris