Launchpad itself

Merge lp:~brian-murray/launchpad/fix-date-closed-definition into lp:launchpad

  1. fix-date-closed-definition
  2. Merge into devel
Proposed by Brian Murray on 2010-04-05
Status: Merged
Approved by: Brad Crittenden on 2010-04-06
Approved revision: no longer in the source branch.
Merged at revision: not available
Proposed branch: lp:~brian-murray/launchpad/fix-date-closed-definition
Merge into: lp:launchpad
Diff against target: 12 lines (+1/-1)
1 file modified
lib/lp/bugs/interfaces/bugtask.py (+1/-1)
To merge this branch: bzr merge lp:~brian-murray/launchpad/fix-date-closed-definition
Reviewer Review Type Date Requested Status
Brad Crittenden (community) code 2010-04-05 Approve on 2010-04-06
Review via email: mp+22836@code.launchpad.net

Commit Message

Clarify the definition of the date_closed attribute of a bug task in the API.

Description of the Change

The date_closed attribute of a bug task is set when a bug transitions to a status in RESOLVED_BUGTASK_STATUSES. These include Won't Fix, Fix Released and Invalid. However, the description of date_closed as exported in the API describes date_closed as indicating when the bug becomes Fix Committed or Fix Released. This branch fixes the date_closed definition in the API.

To post a comment you must log in.
Brad Crittenden (bac) :
review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/bugs/interfaces/bugtask.py'
2--- lib/lp/bugs/interfaces/bugtask.py 2010-03-10 22:19:37 +0000
3+++ lib/lp/bugs/interfaces/bugtask.py 2010-04-05 21:57:22 +0000
4@@ -461,7 +461,7 @@
5 date_closed = exported(
6 Datetime(title=_("Date Closed"),
7 description=_("The date on which this task was marked "
8- "either Fix Committed or Fix Released."),
9+ "either Won't Fix, Invalid or Fix Released."),
10 readonly=True,
11 required=False))
12 date_left_new = exported(