Merge lp:~brian-murray/launchpad/api-export-coc into lp:launchpad

Proposed by Brian Murray
Status: Merged
Approved by: Jonathan Lange
Approved revision: not available
Merged at revision: not available
Proposed branch: lp:~brian-murray/launchpad/api-export-coc
Merge into: lp:launchpad
Diff against target: 36 lines (+5/-3)
2 files modified
lib/lp/registry/interfaces/person.py (+3/-3)
lib/lp/registry/stories/webservice/xx-person.txt (+2/-0)
To merge this branch: bzr merge lp:~brian-murray/launchpad/api-export-coc
Reviewer Review Type Date Requested Status
Jonathan Lange (community) Approve
Review via email: mp+18407@code.launchpad.net

Commit message

Export is_ubuntu_coc_signer for people and teams.

To post a comment you must log in.
Revision history for this message
Brian Murray (brian-murray) wrote :

This branch exports is_ubuntu_coc_signer in API for people and teams which is something I'd like to be able to access.

Revision history for this message
Robert Collins (lifeless) wrote :

Perhaps a test? The actual change looks fine to me.

-Rob

Revision history for this message
Jonathan Lange (jml) wrote :

That's enough of a test for this sort of change.

review: Approve
Revision history for this message
Jonathan Lange (jml) wrote :

Brian, would you like me to land the branch for you?

Revision history for this message
Brian Murray (brian-murray) wrote :

Yes, that would be great as I'm not setup for ec2 testing yet.

Revision history for this message
Jonathan Lange (jml) wrote :

Running through ec2 test now.

Revision history for this message
Brian Murray (brian-murray) wrote :

Did the ec2 test pass?

Revision history for this message
Jonathan Lange (jml) wrote :

No, it must have hanged. Will try again.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/registry/interfaces/person.py'
2--- lib/lp/registry/interfaces/person.py 2010-01-15 01:37:34 +0000
3+++ lib/lp/registry/interfaces/person.py 2010-02-01 20:40:35 +0000
4@@ -618,9 +618,9 @@
5 is_valid_person_or_team = exported(
6 Bool(title=_("This is an active user or a team."), readonly=True),
7 exported_as='is_valid')
8- is_ubuntu_coc_signer = Bool(
9- title=_("Signed Ubuntu Code of Conduct"),
10- readonly=True)
11+ is_ubuntu_coc_signer = exported(
12+ Bool(title=_("Signed Ubuntu Code of Conduct"),
13+ readonly=True))
14 activesignatures = Attribute("Retrieve own Active CoC Signatures.")
15 inactivesignatures = Attribute("Retrieve own Inactive CoC Signatures.")
16 signedcocs = Attribute("List of Signed Code Of Conduct")
17
18=== modified file 'lib/lp/registry/stories/webservice/xx-person.txt'
19--- lib/lp/registry/stories/webservice/xx-person.txt 2010-01-14 22:58:12 +0000
20+++ lib/lp/registry/stories/webservice/xx-person.txt 2010-02-01 20:40:35 +0000
21@@ -21,6 +21,7 @@
22 invited_members_collection_link: u'http://.../~salgado/invited_members'
23 irc_nicknames_collection_link: u'http://.../~salgado/irc_nicknames'
24 is_team: False
25+ is_ubuntu_coc_signer: False
26 is_valid: True
27 jabber_ids_collection_link: u'http://.../~salgado/jabber_ids'
28 karma: 0
29@@ -65,6 +66,7 @@
30 invited_members_collection_link: u'http://.../~ubuntu-team/invited_members'
31 irc_nicknames_collection_link: u'http://.../~ubuntu-team/irc_nicknames'
32 is_team: True
33+ is_ubuntu_coc_signer: False
34 is_valid: True
35 jabber_ids_collection_link: u'http://.../~ubuntu-team/jabber_ids'
36 karma: 0