Merge lp:~brian-murray/daisy/src-version-buckets into lp:daisy
Proposed by
Brian Murray
Status: | Merged |
---|---|
Merged at revision: | 283 |
Proposed branch: | lp:~brian-murray/daisy/src-version-buckets |
Merge into: | lp:daisy |
Diff against target: |
68 lines (+46/-0) 2 files modified
daisy/utils.py (+4/-0) tools/build_src_version_buckets.py (+42/-0) |
To merge this branch: | bzr merge lp:~brian-murray/daisy/src-version-buckets |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Daisy Pluckers | Pending | ||
Review via email: mp+155631@code.launchpad.net |
Description of the change
This branch will start recording to SourceVersionBu
To post a comment you must log in.
Mostly looks good. Feel free to merge once you've addressed the points
below.
On Tue, Mar 26, 2013 at 9:57 PM, Brian Murray <email address hidden> wrote: update_ source_ version_ buckets( oops_config, src_package,
>
> + oopses.
> + version, crash_signature)
>
Can you make this a if hasattr(oopses, 'update_ source_ version_ buckets' ) so
that we don't crash on processing new crashes while we're updating
oops-repository and daisy on production.
> if version: update_ bucket_ versions( oops_config, crash_signature, get_range( columns= cols):
> oopses.
> version)
>
>
> +for key, oops in oops_cf.
> + count += 1
> + if count % 10000 == 0:
> + break
>
I suspect you had this in for debugging?
> + release = oops['DistroRel ease']. encode( 'utf8')
>
oops.get. You're not guaranteed to get rows with all the column names you
specified.
> + startswith( 'Ubuntu '): ].split( ' ')
> + if not release.
> + continue
> + package_data = oops['Package'
+ if len(package_data) < 2:
> + continue
> + version = package_data[1]
>
Please use daisy.utils. split_package_ and_version instead, as it catches
some corner cases (hopefully).
+ src_package = oops['SourcePac kage']
>
oops.get.
> + srcversbucketsi nsert(( src_package, version), {oops_id : ''})
>
Typo :)