APT

Merge lp:~brian-murray/apt/fixed-string-matching into lp:~ubuntu-core-dev/apt/ubuntu

Proposed by Brian Murray
Status: Merged
Merged at revision: 1886
Proposed branch: lp:~brian-murray/apt/fixed-string-matching
Merge into: lp:~ubuntu-core-dev/apt/ubuntu
Diff against target: 40 lines (+9/-3)
2 files modified
apt-pkg/deb/dpkgpm.cc (+2/-2)
debian/changelog (+7/-1)
To merge this branch: bzr merge lp:~brian-murray/apt/fixed-string-matching
Reviewer Review Type Date Requested Status
Ubuntu Core Development Team Pending
Review via email: mp+64756@code.launchpad.net

Description of the change

Reviewing apt's bug report handling and dpkg it seems that one error message is 'cannot access archive' as opposed to 'Cannot ...'. This fixes that. Additionally, dpkg doesn't use 'cannot allocate memory' as an error any more, rather it is now 'failed to allocate' memory.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'apt-pkg/deb/dpkgpm.cc'
2--- apt-pkg/deb/dpkgpm.cc 2011-06-06 14:36:28 +0000
3+++ apt-pkg/deb/dpkgpm.cc 2011-06-15 21:23:32 +0000
4@@ -1317,14 +1317,14 @@
5
6 // do not report out-of-memory failures
7 if(strstr(errormsg, strerror(ENOMEM)) != NULL ||
8- strstr(errormsg, "Cannot allocate memory") != NULL) {
9+ strstr(errormsg, "failed to allocate memory") != NULL) {
10 std::clog << _("No apport report written because the error message indicates a out of memory error") << std::endl;
11 return;
12 }
13
14 // do not report bugs regarding inaccessible local files
15 if(strstr(errormsg, strerror(ENOENT)) != NULL ||
16- strstr(errormsg, "Cannot access archive") != NULL) {
17+ strstr(errormsg, "cannot access archive") != NULL) {
18 std::clog << _("No apport report written because the error message indicates an issue on the local system") << std::endl;
19 return;
20 }
21
22=== modified file 'debian/changelog'
23--- debian/changelog 2011-06-10 14:12:28 +0000
24+++ debian/changelog 2011-06-15 21:23:32 +0000
25@@ -1,9 +1,15 @@
26 apt (0.8.14.1ubuntu8) UNRELEASED; urgency=low
27
28+ [ Michael Vogt ]
29 * debian/apt.conf.changelog:
30 - add missing ";", thanks to Julian Andres Klode
31
32- -- Michael Vogt <michael.vogt@ubuntu.com> Fri, 10 Jun 2011 16:11:26 +0200
33+ [ Brian Murray ]
34+ * apt-pkg/deb/dpkgpm.cc:
35+ - updated allocate memory string
36+ - cannot access archive string is lowercase
37+
38+ -- Brian Murray <brian@ubuntu.com> Wed, 15 Jun 2011 14:00:43 -0700
39
40 apt (0.8.14.1ubuntu7) oneiric; urgency=low
41

Subscribers

People subscribed via source and target branches

to all changes: