Merge lp:~brian-murray/apport/fix-SAS-generation into lp:apport

Proposed by Brian Murray on 2016-01-13
Status: Rejected
Rejected by: Martin Pitt on 2016-01-26
Proposed branch: lp:~brian-murray/apport/fix-SAS-generation
Merge into: lp:apport
Diff against target: 22 lines (+5/-1)
1 file modified
apport/report.py (+5/-1)
To merge this branch: bzr merge lp:~brian-murray/apport/fix-SAS-generation
Reviewer Review Type Date Requested Status
Martin Pitt 2016-01-13 Disapprove on 2016-01-26
Review via email: mp+282476@code.launchpad.net
To post a comment you must log in.
3046. By Brian Murray on 2016-01-14

remove apport-retrace change

Martin Pitt (pitti) wrote :

Conceptually this looks wrong to me, so I reject this for now, sorry. Let's continue discussion in the bug what we really want to fix here. Thanks!

review: Disapprove

Unmerged revisions

3046. By Brian Murray on 2016-01-14

remove apport-retrace change

3045. By Brian Murray on 2016-01-12

Only use crash_signature_addresses() as a fallback and prefer crash_signature().

3044. By Brian Murray on 2016-01-06

If we cannot write to the output file, write to a new report rather than crash.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'apport/report.py'
2--- apport/report.py 2015-10-27 13:05:47 +0000
3+++ apport/report.py 2016-01-14 16:46:50 +0000
4@@ -673,6 +673,8 @@
5 inclusion into bug reports and easier processing
6 - AssertionMessage: Value of __abort_msg, __glib_assert_msg, or
7 __nih_abort_msg if present
8+ - StacktraceAddressSignature: A signature suitable for identifying
9+ duplicates.
10
11 The optional rootdir can specify a root directory which has the
12 executable, libraries, and debug symbols. This does not require
13@@ -751,7 +753,9 @@
14
15 if 'Stacktrace' in self:
16 self._gen_stacktrace_top()
17- addr_signature = self.crash_signature_addresses()
18+ addr_signature = self.crash_signature()
19+ if not addr_signature:
20+ addr_signature = self.crash_signature_addresses()
21 if addr_signature:
22 self['StacktraceAddressSignature'] = addr_signature
23

Subscribers

People subscribed via source and target branches