Merge lp:~brian-murray/apport/check-cdrom into lp:apport

Proposed by Brian Murray on 2011-06-13
Status: Rejected
Rejected by: Martin Pitt on 2011-10-14
Proposed branch: lp:~brian-murray/apport/check-cdrom
Merge into: lp:apport
Diff against target: 11 lines (+1/-0)
1 file modified
data/general-hooks/generic.py (+1/-0)
To merge this branch: bzr merge lp:~brian-murray/apport/check-cdrom
Reviewer Review Type Date Requested Status
Martin Pitt 2011-06-13 Disapprove on 2011-10-14
Review via email: mp+64444@code.launchpad.net

Description of the change

Looking at casper it seems that the root filesytem on Live Media, like a persistent USB stick, is mounted as /cdrom. I've updated generic.py to check /cdrom for low free space before reporting a bug.

To post a comment you must log in.
Martin Pitt (pitti) wrote :

/cdrom is a read-only mount in the live system as well as installed systems, so it'll always be 100% full. I don't think it's interesting at all apport-wise.

On a live system the only interesting mount is /, as this has the combined read-write system partition.

review: Needs Fixing
Martin Pitt (pitti) wrote :

Most likely this is not necessary at all, but keeping open for the case that you intended to check for something different.

Martin Pitt (pitti) wrote :

No response for four months, and this looks unintended, closing. Please reopen if you still think that there's something wrong here. Thanks!

review: Disapprove

Unmerged revisions

1902. By Brian Murray on 2011-06-13

check for low space in root filesystem on persistent media

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/general-hooks/generic.py'
2--- data/general-hooks/generic.py 2011-06-12 19:07:37 +0000
3+++ data/general-hooks/generic.py 2011-06-13 18:53:22 +0000
4@@ -22,6 +22,7 @@
5 # check for low space
6 mounts = {'/': 'system',
7 '/var': '/var',
8+ '/cdrom': 'system'
9 }
10
11 home = os.getenv('HOME')

Subscribers

People subscribed via source and target branches