Merge lp:~brian-murray/apport/bug-1345653 into lp:apport

Proposed by Brian Murray on 2015-02-23
Status: Rejected
Rejected by: Martin Pitt on 2015-02-26
Proposed branch: lp:~brian-murray/apport/bug-1345653
Merge into: lp:apport
Diff against target: 15 lines (+4/-1)
1 file modified
apport/report.py (+4/-1)
To merge this branch: bzr merge lp:~brian-murray/apport/bug-1345653
Reviewer Review Type Date Requested Status
Martin Pitt 2015-02-23 Disapprove on 2015-02-26
Review via email: mp+250673@code.launchpad.net
To post a comment you must log in.
Martin Pitt (pitti) wrote :

This ignores the error at a too low layer. IMHO it should rather handle it the same way as for icthread in ui.py collect_info(). Fixed in http://bazaar.launchpad.net/~apport-hackers/apport/trunk/revision/2917

Thanks for pointing out!

review: Disapprove

Unmerged revisions

2912. By Brian Murray on 2015-02-23

continue to the next pattern if we encounter an EOFError reading a value

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'apport/report.py'
2--- apport/report.py 2015-02-10 10:21:40 +0000
3+++ apport/report.py 2015-02-23 20:26:26 +0000
4@@ -139,7 +139,10 @@
5 regexp = regexp.encode('UTF-8')
6 v = report[key]
7 if isinstance(v, problem_report.CompressedValue):
8- v = v.get_value()
9+ try:
10+ v = v.get_value()
11+ except EOFError:
12+ continue
13 if not _python2:
14 regexp = regexp.encode('UTF-8')
15 elif isinstance(v, bytes):

Subscribers

People subscribed via source and target branches