Apport

Merge lp:~brian-murray/apport/bug-1329520 into lp:~apport-hackers/apport/trunk

  1. bug-1329520
  2. Merge into trunk
Proposed by Brian Murray
Status: Merged
Merged at revision: 2821
Proposed branch: lp:~brian-murray/apport/bug-1329520
Merge into: lp:~apport-hackers/apport/trunk
Diff against target: 16 lines (+5/-1)
1 file modified
data/whoopsie-upload-all (+5/-1)
To merge this branch: bzr merge lp:~brian-murray/apport/bug-1329520
Reviewer Review Type Date Requested Status
Martin Pitt (community) Approve
Review via email: mp+228579@code.launchpad.net

Description of the change

This adds some error handling for crash files with incomplete CoreDumps like unity8 produces.

To post a comment you must log in.
Revision history for this message
Martin Pitt (pitti) wrote :

Thanks! I'll merge with a NEWS entry.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/whoopsie-upload-all'
2--- data/whoopsie-upload-all 2014-07-02 06:31:13 +0000
3+++ data/whoopsie-upload-all 2014-07-28 21:40:59 +0000
4@@ -52,7 +52,11 @@
5 else:
6 print('Collecting info for %s...' % report)
7 r.add_os_info()
8- r.add_gdb_info()
9+ try:
10+ r.add_gdb_info()
11+ except EOFError as e:
12+ sys.stderr.write('ERROR: processing %s: %s\n' % (report, str(e)))
13+ return None
14 try:
15 r.add_package_info()
16 except (SystemError, ValueError) as e:

Subscribers

People subscribed via source and target branches