Merge lp:~brendan-donegan/ubuntu/raring/checkbox/0.15.5 into lp:ubuntu/raring/checkbox

Proposed by Brendan Donegan
Status: Needs review
Proposed branch: lp:~brendan-donegan/ubuntu/raring/checkbox/0.15.5
Merge into: lp:ubuntu/raring/checkbox
Diff against target: 55 lines (+21/-5)
3 files modified
checkbox/parsers/udevadm.py (+6/-1)
debian/changelog (+12/-0)
scripts/udev_resource (+3/-4)
To merge this branch: bzr merge lp:~brendan-donegan/ubuntu/raring/checkbox/0.15.5
Reviewer Review Type Date Requested Status
Daniel Manrique Pending
Review via email: mp+155014@code.launchpad.net

Description of the change

* New upstream release (LP: #1158798)
* scripts/udev_resource: Set the decoding error policy to 'ignore' to avoid
  breaking tests that depends on the udevadm resource (LP: #1151562)
* scripts/udev_resource: Identify KVM devices as such to avoid reporting them
  as just CAPTURE devices (LP: #1065064)

To post a comment you must log in.

Unmerged revisions

1883. By Brendan Donegan

* New upstream release (LP: #1158798)

* scripts/udev_resource: Set the decoding error policy to 'ignore' to avoid
  breaking tests that depends on the udevadm resource (LP: #1151562)
* scripts/udev_resource: Identify KVM devices as such to avoid reporting them
  as just CAPTURE devices (LP: #1065064)

1882. By Brendan Donegan

Include fix for Bug #1151562 in Ubuntu candidate.

1881. By Brendan Donegan

Incremented version in changelog and added candidate revision bug

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'checkbox/parsers/udevadm.py'
2--- checkbox/parsers/udevadm.py 2013-03-07 15:52:02 +0000
3+++ checkbox/parsers/udevadm.py 2013-03-22 16:55:31 +0000
4@@ -210,7 +210,12 @@
5 return "KEYBOARD"
6
7 if test_bit(Input.KEY_CAMERA, bitmask, self._bits):
8- return "CAPTURE"
9+ # Consider a device with both camera and mouse properties as a
10+ # KVM hardware device ("keyboard, video and mouse")
11+ if test_bit(Input.BTN_MOUSE, bitmask, self._bits):
12+ return "KVM"
13+ else:
14+ return "CAPTURE"
15
16 if test_bit(Input.BTN_TOUCH, bitmask, self._bits):
17 return "TOUCH"
18
19=== modified file 'debian/changelog'
20--- debian/changelog 2013-03-07 15:52:02 +0000
21+++ debian/changelog 2013-03-22 16:55:31 +0000
22@@ -1,3 +1,15 @@
23+checkbox (0.15.5) raring; urgency=low
24+
25+ * New upstream release (LP: #1158798)
26+
27+ [Sylvain Pineau]
28+ * scripts/udev_resource: Set the decoding error policy to 'ignore' to avoid
29+ breaking tests that depends on the udevadm resource (LP: #1151562)
30+ * scripts/udev_resource: Identify KVM devices as such to avoid reporting them
31+ as just CAPTURE devices (LP: #1065064)
32+
33+ -- Brendan Donegan <brendan.donegan@canonical.com> Fri, 22 Mar 2013 16:14:06 +0000
34+
35 checkbox (0.15.4) raring; urgency=low
36
37 * New upstream release (LP: #1152223)
38
39=== modified file 'scripts/udev_resource'
40--- scripts/udev_resource 2013-03-07 15:52:02 +0000
41+++ scripts/udev_resource 2013-03-22 16:55:31 +0000
42@@ -43,10 +43,9 @@
43 output = check_output(['udevadm', 'info', '--export-db'])
44 except CalledProcessError as exc:
45 raise SystemExit(exc)
46- try:
47- output = output.decode("UTF-8")
48- except UnicodeDecodeError as exc:
49- raise SystemExit("udevadm output is not valid UTF-8")
50+ # Set the error policy to 'ignore' in order to let tests depending on this
51+ # resource to properly match udev properties
52+ output = output.decode("UTF-8", errors='ignore')
53 udev = UdevadmParser(output)
54 result = UdevResult()
55 udev.run(result)

Subscribers

People subscribed via source and target branches