Merge lp:~brendan-donegan/ubuntu-system-settings/bug1319711 into lp:ubuntu-system-settings

Proposed by Brendan Donegan
Status: Merged
Approved by: Iain Lane
Approved revision: 724
Merged at revision: 725
Proposed branch: lp:~brendan-donegan/ubuntu-system-settings/bug1319711
Merge into: lp:ubuntu-system-settings
Diff against target: 11 lines (+1/-1)
1 file modified
tests/autopilot/ubuntu_system_settings/tests/test_datetime.py (+1/-1)
To merge this branch: bzr merge lp:~brendan-donegan/ubuntu-system-settings/bug1319711
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Iain Lane Approve
Review via email: mp+222141@code.launchpad.net

Commit message

Make test_tz_list_initially_empty more robust by using wait_select_single instead of select_single to get the label.

Description of the change

Make test_tz_list_initially_empty more robust by using wait_select_single instead of select_single to get the label.

To post a comment you must log in.
Revision history for this message
Iain Lane (laney) wrote :

It's worth a go, thanks.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:724
http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-ci/859/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/682
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/624
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-utopic-amd64-ci/51
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-utopic-armhf-ci/51
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-utopic-armhf-ci/51/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-utopic-i386-ci/51
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/1113
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/1294
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/1294/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/8106
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/555
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/763
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/763/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/859/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/autopilot/ubuntu_system_settings/tests/test_datetime.py'
2--- tests/autopilot/ubuntu_system_settings/tests/test_datetime.py 2014-04-04 15:31:49 +0000
3+++ tests/autopilot/ubuntu_system_settings/tests/test_datetime.py 2014-06-05 09:24:41 +0000
4@@ -62,7 +62,7 @@
5 def test_tz_list_initially_empty(self):
6 """ Checks that no list is displayed initially """
7 self.system_settings.main_view.scroll_to_and_click(self.tz_page)
8- labelVisible = self.system_settings.main_view.select_single(
9+ labelVisible = self.system_settings.main_view.wait_select_single(
10 objectName='nothingLabel').visible
11 self.assertThat(labelVisible, Equals(True))
12

Subscribers

People subscribed via source and target branches