Merge lp:~brendan-donegan/ubuntu-clock-app/wait_for_bottomedgetip_visible into lp:ubuntu-clock-app

Proposed by Brendan Donegan
Status: Merged
Approved by: Nekhelesh Ramananthan
Approved revision: 178
Merged at revision: 179
Proposed branch: lp:~brendan-donegan/ubuntu-clock-app/wait_for_bottomedgetip_visible
Merge into: lp:ubuntu-clock-app
Diff against target: 20 lines (+2/-3)
1 file modified
tests/autopilot/ubuntu_clock_app/emulators.py (+2/-3)
To merge this branch: bzr merge lp:~brendan-donegan/ubuntu-clock-app/wait_for_bottomedgetip_visible
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Leo Arias (community) Approve
Review via email: mp+242792@code.launchpad.net

Commit message

Wait for the bottomEdgeTip 'visible' property to be True

Description of the change

Wait for the bottomEdgeTip 'visible' property to be True, the other wait_for's (on enable and 'hiden') were red herrings.

To post a comment you must log in.
Revision history for this message
Brendan Donegan (brendan-donegan) wrote :

I've no idea how the diff got like that

Revision history for this message
Brendan Donegan (brendan-donegan) :
Revision history for this message
Leo Arias (elopio) wrote :

Looks good to me. Please confirm that the tests are passing in Jenkins before merging.

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/autopilot/ubuntu_clock_app/emulators.py'
2--- tests/autopilot/ubuntu_clock_app/emulators.py 2014-10-14 11:25:35 +0000
3+++ tests/autopilot/ubuntu_clock_app/emulators.py 2014-11-25 15:19:01 +0000
4@@ -91,8 +91,7 @@
5 self.bottomEdgePageLoaded.wait_for(True)
6 try:
7 action_item = self.wait_select_single(objectName='bottomEdgeTip')
8- action_item.hiden.wait_for(False)
9- action_item.enabled.wait_for(True)
10+ action_item.visible.wait_for(True)
11 action_item.isAnimating.wait_for(False)
12 start_x = (action_item.globalRect.x +
13 (action_item.globalRect.width * 0.5))
14@@ -544,4 +543,4 @@
15 class AlarmDelegate(ListItemWithActions):
16
17 def __init__(self, *args):
18- super(AlarmDelegate, self).__init__(*args)
19\ No newline at end of file
20+ super(AlarmDelegate, self).__init__(*args)

Subscribers

People subscribed via source and target branches