Merge lp:~brendan-donegan/sudoku-app/fix_test_profile_setupp into lp:sudoku-app

Proposed by Brendan Donegan on 2014-08-19
Status: Work in progress
Proposed branch: lp:~brendan-donegan/sudoku-app/fix_test_profile_setupp
Merge into: lp:sudoku-app
Diff against target: 12 lines (+1/-1)
1 file modified
tests/autopilot/sudoku_app/tests/settings/test_profiles.py (+1/-1)
To merge this branch: bzr merge lp:~brendan-donegan/sudoku-app/fix_test_profile_setupp
Reviewer Review Type Date Requested Status
Leo Arias (community) 2014-08-19 Needs Information on 2014-08-19
Review via email: mp+231321@code.launchpad.net

Description of the change

setUp was being called on the parent of ProfilesTestCase using 'super().setUp()'. This couldn't work so this branch fixes it to specify 'super(ProfilesTestCase, self).setUp()' which is correct.

To post a comment you must log in.
Leo Arias (elopio) wrote :

I don't get what do you mean with. super().setUp() will work if you run the tests with autopilot3.
And all the tests passed when the branch was landing: https://code.launchpad.net/~canonical-platform-qa/sudoku-app/clean_tests1/+merge/228236

Also, please remember to propose branches as ~canonical-platform-qa so we all get notified.

review: Needs Information

Unmerged revisions

262. By Brendan Donegan on 2014-08-19

Properly call setUp on the parent of ProfilesTestCase

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/autopilot/sudoku_app/tests/settings/test_profiles.py'
2--- tests/autopilot/sudoku_app/tests/settings/test_profiles.py 2014-07-29 23:33:40 +0000
3+++ tests/autopilot/sudoku_app/tests/settings/test_profiles.py 2014-08-19 09:04:22 +0000
4@@ -21,7 +21,7 @@
5 class ProfilesTestCase(tests.SudokuTestCase):
6
7 def setUp(self):
8- super().setUp()
9+ super(ProfilesTestCase, self).setUp()
10 self.settings_page = self.app.main_view.go_to_settings()
11
12 def add_new_test_profile(self):

Subscribers

People subscribed via source and target branches