Merge lp:~brendan-donegan/qtubuntu-sensors/bug1337284 into lp:qtubuntu-sensors

[Brendan Donegan]

Initialize m_last{X,Y,Z} to avoid faulty values

The values of m_lastX, m_lastY and m_lastZ were not being initialized on creation. This allowed some faulty values to get through and corrupt the logic of the function, meaning that sometimes a rotation event could be issued for no reason. This branch fixes that, and I've tested that in the scenario where the unexpected rotation would occur, it no longer does.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:70
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~brendan-donegan/qtubuntu-sensors/bug1337284/+merge/225840/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/qtubuntu-sensors-ci/56/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtubuntu-sensors-utopic-amd64-ci/22
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtubuntu-sensors-utopic-armhf-ci/18
        deb: http://jenkins.qa.ubuntu.com/job/qtubuntu-sensors-utopic-armhf-ci/18/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtubuntu-sensors-utopic-i386-ci/18

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtubuntu-sensors-ci/56/rebuild

review: Needs Fixing (continuous-integration)

[Olivier Tilloy (osomon)]

So, the issue really was random after all, not tied to the use of the "-testability" flag, nor to the page that was being browsed?

[Brendan Donegan (brendan-donegan)]

It's likely to be timing related, which the use of -testability and the exact content of the page to be loaded would obviously contribute to.

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:70
http://jenkins.qa.ubuntu.com/job/qtubuntu-sensors-ci/57/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtubuntu-sensors-utopic-amd64-ci/23
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtubuntu-sensors-utopic-armhf-ci/19
        deb: http://jenkins.qa.ubuntu.com/job/qtubuntu-sensors-utopic-armhf-ci/19/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtubuntu-sensors-utopic-i386-ci/19

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtubuntu-sensors-ci/57/rebuild

review: Approve (continuous-integration)

[Ricardo Mendoza (ricmm)]

Well I believe testability is doing something to var initialization. The uninitialized vars were taking different values when using it against not using it. This might be a bit of a concern, as it means that it can introduce different behaviour where unexpected values might come in.

Other than that, this branch works fine. Approved.

review: Approve

=== modified file 'plugins/sensors/core_orientation_sensor.cpp'
--- plugins/sensors/core_orientation_sensor.cpp	2014-06-18 14:44:26 +0000
+++ plugins/sensors/core_orientation_sensor.cpp	2014-07-07 14:39:22 +0000
@@ -42,7 +42,7 @@
 };
 
 core::OrientationSensor::OrientationSensor(QSensor *sensor)
-    : QSensorBackend(sensor)
+    : QSensorBackend(sensor), m_lastX(0), m_lastY(0), m_lastZ(0)
 {
     // Register the reading instance with the parent
     setReading<QOrientationReading>(&m_reading);