qakit

Merge lp:~brendan-donegan/qakit/no_report_skip into lp:qakit

  1. no_report_skip
  2. Merge into trunk
Proposed by Brendan Donegan
Status: Merged
Approved by: Allan LeSage
Approved revision: 11
Merged at revision: 13
Proposed branch: lp:~brendan-donegan/qakit/no_report_skip
Merge into: lp:qakit
Diff against target: 12 lines (+4/-1)
1 file modified
qakit/practitest/practisubunit.py (+4/-1)
To merge this branch: bzr merge lp:~brendan-donegan/qakit/no_report_skip
Reviewer Review Type Date Requested Status
Allan LeSage (community) Approve
Review via email: mp+269249@code.launchpad.net

Commit message

Don't upload results for tests that don't have a result of either Pass or Fail in subunit

Description of the change

Tests that don't have an explicit Pass or Fail in subunit should not be uploaded as either a Pass or a Fail (as we're forced to do so now by limitation of the API). Skip uploading the test if the result is neither Pass nor Fail. We may revisit this if we can convince PractiTest to improve the API.

To post a comment you must log in.
Revision history for this message
Allan LeSage (allanlesage) wrote :

No objection, LG.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'qakit/practitest/practisubunit.py'
2--- qakit/practitest/practisubunit.py 2015-06-26 00:16:01 +0000
3+++ qakit/practitest/practisubunit.py 2015-08-26 17:41:54 +0000
4@@ -121,4 +121,7 @@
5
6 def report_to_practitest(self):
7 for result in self.results:
8- self.practisubunit_session.upload_test_result(result)
9+ # PractiTest can only handle absolute passes and fails with the
10+ # automated tests API
11+ if result['subunit_test_result']['status'] in ('success', 'fail'):
12+ self.practisubunit_session.upload_test_result(result)

Subscribers

People subscribed via source and target branches