Merge lp:~brendan-donegan/phablet-tools/bug1411697 into lp:phablet-tools

Proposed by Brendan Donegan
Status: Needs review
Proposed branch: lp:~brendan-donegan/phablet-tools/bug1411697
Merge into: lp:phablet-tools
Diff against target: 16 lines (+4/-2)
1 file modified
phablet-test-run (+4/-2)
To merge this branch: bzr merge lp:~brendan-donegan/phablet-tools/bug1411697
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Christian Dywan (community) Approve
Review via email: mp+246725@code.launchpad.net

Commit message

Use exec_with_adb_user to create the temporary directory for pushing .deb files to

Description of the change

Create the temporary directory for copying .deb files to with exec_with_adb_user so that files can be adb pushed there without a permissions error

To post a comment you must log in.
Revision history for this message
Christian Dywan (kalikiana) wrote :

This won't suffice for deleting an existing problematic folder. You need "exec_with_adb rm -rf /tmp/phablet-run-test/" to remove it in all cases.

review: Needs Fixing
335. By Brendan Donegan

Remove /tmp/phablet-run-test as root in case it exists from a previous run of the buggy version of phablet-test-run

336. By Brendan Donegan

No need for the second call to rm -rf

Revision history for this message
Brendan Donegan (brendan-donegan) wrote :

> This won't suffice for deleting an existing problematic folder. You need
> "exec_with_adb rm -rf /tmp/phablet-run-test/" to remove it in all cases.

Thanks, that is a possible corner case. Doing that makes the second call to rm -rf redundant too so I removed that

Revision history for this message
Christian Dywan (kalikiana) wrote :

Looking nice!

I'm obviously not a phablet team member, so I'm just approving this based on the fact that it solves the problems I was experiencing and somebody official will have to look into it.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Christian Dywan (kalikiana) wrote :

Any chance this will be reviewed?

Unmerged revisions

336. By Brendan Donegan

No need for the second call to rm -rf

335. By Brendan Donegan

Remove /tmp/phablet-run-test as root in case it exists from a previous run of the buggy version of phablet-test-run

334. By Brendan Donegan

Create temporary directory as the phablet user

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'phablet-test-run'
2--- phablet-test-run 2014-09-28 16:43:50 +0000
3+++ phablet-test-run 2015-01-16 16:03:51 +0000
4@@ -97,8 +97,10 @@
5 fi
6
7 if test -n "$LOCALPACKAGES"; then
8- exec_with_adb mkdir -p /tmp/phablet-run-test/
9- exec_with_adb rm -rf /tmp/phablet-run-test/*
10+ # Old versions of this script created this directory
11+ # as root so we need to remove it as root just incase
12+ exec_with_adb rm -rf /tmp/phablet-run-test
13+ exec_with_adb_user mkdir -p /tmp/phablet-run-test/
14 PACKAGELIST=""
15 for PACKAGEPATH in $LOCALPACKAGES; do
16 PACKAGE=$(basename $PACKAGEPATH)

Subscribers

People subscribed via source and target branches