Merge lp:~brendan-donegan/phablet-tools/bug1411697 into lp:phablet-tools

[Brendan Donegan]

Use exec_with_adb_user to create the temporary directory for pushing .deb files to

Create the temporary directory for copying .deb files to with exec_with_adb_user so that files can be adb pushed there without a permissions error

[Cris Dywan (kalikiana)]

This won't suffice for deleting an existing problematic folder. You need "exec_with_adb rm -rf /tmp/phablet-run-test/" to remove it in all cases.

review: Needs Fixing

[lp:~brendan-donegan/phablet-tools/bug1411697]

335. By Brendan Donegan on 2015-01-16

Remove /tmp/phablet-run-test as root in case it exists from a previous run of the buggy version of phablet-test-run

336. By Brendan Donegan on 2015-01-16

No need for the second call to rm -rf

[Brendan Donegan (brendan-donegan)]

> This won't suffice for deleting an existing problematic folder. You need
> "exec_with_adb rm -rf /tmp/phablet-run-test/" to remove it in all cases.

Thanks, that is a possible corner case. Doing that makes the second call to rm -rf redundant too so I removed that

[Cris Dywan (kalikiana)]

Looking nice!

I'm obviously not a phablet team member, so I'm just approving this based on the fact that it solves the problems I was experiencing and somebody official will have to look into it.

review: Approve

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:334
http://jenkins.qa.ubuntu.com/job/phablet-tools-ci/432/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-tools-vivid-amd64-ci/9
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-tools-vivid-armhf-ci/9
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-tools-vivid-i386-ci/9

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/phablet-tools-ci/432/rebuild

review: Approve (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:336
http://jenkins.qa.ubuntu.com/job/phablet-tools-ci/433/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-tools-vivid-amd64-ci/10
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-tools-vivid-armhf-ci/10
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-tools-vivid-i386-ci/10

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/phablet-tools-ci/433/rebuild

review: Approve (continuous-integration)

[Cris Dywan (kalikiana)]

Any chance this will be reviewed?

Unmerged revisions

336. By Brendan Donegan on 2015-01-16

No need for the second call to rm -rf

335. By Brendan Donegan on 2015-01-16

Remove /tmp/phablet-run-test as root in case it exists from a previous run of the buggy version of phablet-test-run

334. By Brendan Donegan on 2015-01-16

Create temporary directory as the phablet user

=== modified file 'phablet-test-run'
--- phablet-test-run	2014-09-28 16:43:50 +0000
+++ phablet-test-run	2015-01-16 16:03:51 +0000
@@ -97,8 +97,10 @@
     fi
 
     if test -n "$LOCALPACKAGES"; then
-        exec_with_adb mkdir -p /tmp/phablet-run-test/
-        exec_with_adb rm -rf /tmp/phablet-run-test/*
+        # Old versions of this script created this directory
+        # as root so we need to remove it as root just incase
+        exec_with_adb rm -rf /tmp/phablet-run-test
+        exec_with_adb_user mkdir -p /tmp/phablet-run-test/
         PACKAGELIST=""
         for PACKAGEPATH in $LOCALPACKAGES; do
             PACKAGE=$(basename $PACKAGEPATH)