Merge lp:~brendan-donegan/lpltk/lp-file-bug-lpltk into lp:lpltk

[Brendan Donegan]

Add lp-file-bug which is a simple script which takes a bug title, project name (and possibly package name) and gets a description from the users preferred editor, then proceeds to file a bug in Launchpad without any messing around with browsers - finally the bug url is dumped back to the user for later reference.

A small tweak was made to LaunchpadService to support the fact that it should be possible to file a bug *only* on a project, not necessarily a package in a project. This involved checking for the presence of the 'package' parameter and only tacking on '+source/<package>' if it is present. Hopefully this maintains compatibility with existing scripts.

[Brendan Donegan (brendan-donegan)]

Oh, a question - can I add this to scripts in setup.py?

[Bryce Harrington (bryce)]

Looks good, and yes the script can be added to setup.py. I will take care of that for you.

review: Approve (code)

=== modified file 'AUTHORS'
--- AUTHORS	2011-08-24 20:51:06 +0000
+++ AUTHORS	2012-09-19 21:20:35 +0000
@@ -5,3 +5,4 @@
         Markus Korn <[e-mail]>
         Brad Figg <[e-mail]>
         Brian Murray <[e-mail]>
+        Brendan Donegan <[e-mail]>

=== modified file 'lpltk/LaunchpadService.py'
--- lpltk/LaunchpadService.py	2012-07-11 02:15:18 +0000
+++ lpltk/LaunchpadService.py	2012-09-19 21:20:35 +0000
@@ -249,7 +249,11 @@
     #
     def create_bug(self, project, package, title, description, tags=[]):
         proj    = self.projects[project]
-        target  = self.launchpad.load(proj.self_link + "/+source/" + package);
+        target  = proj.self_link
+
+        if package:
+            target += "/+source/" + package
+
         lp_bug = self.launchpad.bugs.createBug(target=target, title=title, description=description, tags=[])
         return self.get_bug(lp_bug.id)
 

=== added file 'scripts/lp-file-bug'
--- scripts/lp-file-bug	1970-01-01 00:00:00 +0000
+++ scripts/lp-file-bug	2012-09-19 21:20:35 +0000
@@ -0,0 +1,44 @@
+#!/usr/bin/python
+
+import os
+import sys
+
+from argparse import ArgumentParser
+from lpltk import LaunchpadService
+from subprocess import check_call
+from tempfile import NamedTemporaryFile
+
+def main():
+    parser = ArgumentParser("A script for filing new bugs in Launchpad.")
+    parser.add_argument("title",
+                        help="The bug title used to describe it.")
+    parser.add_argument("--project","-p",
+                        help="The project to file the bug against.",
+                        default="ubuntu")
+    parser.add_argument("--package","-P",
+                        help="The package to file the bug against.")
+    args = parser.parse_args()
+
+    lp = LaunchpadService()
+
+    # TODO: Get the description for 'your favourite editor'
+    editor = os.environ.get('EDITOR','nano')
+    tempfile = NamedTemporaryFile(delete=False)
+    try:
+        check_call([editor,tempfile.name])
+    except CalledProcessError:
+        print("Failed to open text editor")
+    description = tempfile.read()
+
+    try:
+        bug = lp.create_bug(args.project, args.package, title=args.title, description=description)
+        print(bug.lp_bug.web_link)
+    except:
+        print("Unable to file bug in:")
+        print("\tproject: %s" % args.project)
+
+        if args.package:
+            print("\tpackage: %s" % args.package)
+
+if __name__ == "__main__":
+    sys.exit(main())