Merge lp:~brendan-donegan/checkbox/plainbox_autostart_pkg into lp:~checkbox-dev/checkbox/plainbox-packaging

Proposed by Brendan Donegan
Status: Merged
Approved by: Brendan Donegan
Approved revision: 16
Merged at revision: 9
Proposed branch: lp:~brendan-donegan/checkbox/plainbox_autostart_pkg
Merge into: lp:~checkbox-dev/checkbox/plainbox-packaging
Diff against target: 49 lines (+18/-1)
4 files modified
debian/changelog (+6/-1)
debian/control (+10/-0)
debian/plainbox-autostart-desktop.install (+1/-0)
debian/plainbox-autostart-server.install (+1/-0)
To merge this branch: bzr merge lp:~brendan-donegan/checkbox/plainbox_autostart_pkg
Reviewer Review Type Date Requested Status
Brendan Donegan (community) Approve
Zygmunt Krynicki (community) Needs Fixing
Review via email: mp+155508@code.launchpad.net

This proposal supersedes a proposal from 2013-03-26.

Description of the change

This merge adds a binary package called plainbox-autostart, which when installed will make it so that plainbox runs when the system in question next boots up

To post a comment you must log in.
Revision history for this message
Zygmunt Krynicki (zyga) wrote : Posted in a previous version of this proposal

Still broken, wrong target branch

review: Needs Fixing
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

Looks good. Let's approve it after the other side lands

review: Approve
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

12 +Description: File(s) needed for starting plainbox automatically on boot.

Actually this is wrong, we start on login, not on boot.

Perhaps you could have plainbox-autostart-boot and plainbox-autostart-session to differentiate the two?

review: Needs Fixing
13. By Brendan Donegan

Corrected description.

Revision history for this message
Brendan Donegan (brendan-donegan) wrote :

Does this work better?

review: Needs Resubmitting
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

> Does this work better?

Yes. I'll hold updating this while https://code.launchpad.net/~brendan-donegan/checkbox/plainbox_autostart/+merge/155502 is still in progress

14. By Brendan Donegan

Last few packaging tweaks and merge from trunk

15. By Brendan Donegan

Reflect renaming of plainbox-autostart.desktop to plainbox.desktop

16. By Brendan Donegan

Correct plainbox-autostart-server description and remove misc:Depends

Revision history for this message
Brendan Donegan (brendan-donegan) wrote :

Self +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2013-03-25 09:51:54 +0000
3+++ debian/changelog 2013-04-11 16:40:30 +0000
4@@ -1,9 +1,14 @@
5 plainbox (0.2-7) raring; urgency=low
6
7+ [ Zygmunt Krynicki ]
8 * Add missing dependency on python3-lxml for python3-plainbox and
9 build-depends
10
11- -- Zygmunt Krynicki <zygmunt.krynicki@canonical.com> Mon, 25 Mar 2013 10:42:11 +0100
12+ [ Brendan Donegan ]
13+ * Add binary package plainbox-autostart which installs files necessary to
14+ have plainbox run automatically when the system starts up.
15+
16+ -- Brendan Donegan <brendan.donegan@canonical.com> Tue, 26 Mar 2013 08:12:39 +0000
17
18 plainbox (0.2-6) raring; urgency=low
19
20
21=== modified file 'debian/control'
22--- debian/control 2013-04-05 20:06:26 +0000
23+++ debian/control 2013-04-11 16:40:30 +0000
24@@ -67,3 +67,13 @@
25 line interface.
26 .
27 This package contains the plainbox executable
28+
29+Package: plainbox-autostart-desktop
30+Architecture: all
31+Depends: plainbox
32+Description: File(s) needed for starting plainbox automatically after login on a desktop install.
33+
34+Package: plainbox-autostart-server
35+Architecture: all
36+Depends: plainbox
37+Description: File(s) needed for starting plainbox automatically after boot on a server install.
38
39=== added file 'debian/plainbox-autostart-desktop.install'
40--- debian/plainbox-autostart-desktop.install 1970-01-01 00:00:00 +0000
41+++ debian/plainbox-autostart-desktop.install 2013-04-11 16:40:30 +0000
42@@ -0,0 +1,1 @@
43+checkbox/plainbox/plainbox/data/plainbox.desktop etc/xdg/autostart
44
45=== added file 'debian/plainbox-autostart-server.install'
46--- debian/plainbox-autostart-server.install 1970-01-01 00:00:00 +0000
47+++ debian/plainbox-autostart-server.install 2013-04-11 16:40:30 +0000
48@@ -0,0 +1,1 @@
49+checkbox/plainbox/plainbox/data/plainbox.conf etc/init

Subscribers

People subscribed via source and target branches