Merge lp:~brendan-donegan/checkbox/fix_minimum_resolution into lp:checkbox

Proposed by Brendan Donegan
Status: Merged
Merged at revision: 1060
Proposed branch: lp:~brendan-donegan/checkbox/fix_minimum_resolution
Merge into: lp:checkbox
Diff against target: 33 lines (+3/-3)
2 files modified
debian/changelog (+1/-0)
scripts/resolution_test (+2/-3)
To merge this branch: bzr merge lp:~brendan-donegan/checkbox/fix_minimum_resolution
Reviewer Review Type Date Requested Status
Marc Tardif (community) Approve
Review via email: mp+76422@code.launchpad.net

Description of the change

The script had a typo where min_h was used twice instead of min_h and min_v as in the function header. Also simplified the logic a bit (no need to use an if statement to modify the return of a boolean function)

To post a comment you must log in.
Revision history for this message
Marc Tardif (cr3) wrote :

Looks good, merging and updating ppa.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2011-09-21 13:33:59 +0000
3+++ debian/changelog 2011-09-21 14:43:18 +0000
4@@ -4,6 +4,7 @@
5 * Remove test for FTP connection from network_check script (LP: #854222)
6 * Update a parameter in usb_test to have it run faster.
7 * Remove record_playback_after_suspend from Ubuntu Friendly whitelist (LP: #855540)
8+ * Fix minor typo in multi-monitor friendly resolution_test script which caused minimum_resolution test to fail (LP: #855599)
9
10 [Daniel Manrique]
11 * Restored _recover attribute, re-enabling welcome and test selection
12
13=== modified file 'scripts/resolution_test'
14--- scripts/resolution_test 2011-09-20 15:42:18 +0000
15+++ scripts/resolution_test 2011-09-21 14:43:18 +0000
16@@ -18,7 +18,7 @@
17 # Evaluate just the primary display
18 screen = Gdk.Screen.get_default()
19 geom = screen.get_monitor_geometry(screen.get_primary_monitor())
20- return geom.width >= min_h and geom.height >= min_h
21+ return geom.width >= min_h and geom.height >= min_v
22
23 def main(args):
24 usage = "Usage: %prog [OPTIONS]"
25@@ -34,8 +34,7 @@
26 (options, args) = parser.parse_args(args)
27
28 if (options.horizontal > 0) and (options.vertical > 0):
29- if not compare_resolution(options.horizontal, options.vertical):
30- return 1
31+ return not compare_resolution(options.horizontal, options.vertical)
32 else:
33 check_resolution()
34

Subscribers

People subscribed via source and target branches