Merge lp:~brendan-donegan/checkbox/fix_get_pointer_error into lp:checkbox

[Brendan Donegan]

As the bug states, this change fixes what looks to be a minor problem where get_pointer is returning a tuple with too many values. Having thought about this a bit, this could actually be the root cause of a few other problems seen in Oneiric, since x and y are the values that are actually used and I think the old version may have been putting the wrong values in them.

[Brendan Donegan (brendan-donegan)]

To aid the review process I should point out that I did check before making this change what the different elements of the tuple actually were by:

w, x, y, z = window.get_pointer()
print(w,x,y,z)

the result being: (None, 150, 280, <flags 0 of type ModifierType>)

So I'm quite sure that the 2nd and 3rd values are in fact the x and y co-ordinates.

[Marc Tardif (cr3)]

Looks good, thanks for the fix!

review: Approve

=== modified file 'checkbox_gtk/hyper_text_view.py'
--- checkbox_gtk/hyper_text_view.py	2011-05-17 13:47:10 +0000
+++ checkbox_gtk/hyper_text_view.py	2011-06-13 10:09:28 +0000
@@ -75,7 +75,7 @@
 
     def _motion(self, view, ev):
         window = ev.window
-        x, y, _ = window.get_pointer()
+        _, x, y, _ = window.get_pointer()
         x, y = view.window_to_buffer_coords(Gtk.TextWindowType.TEXT, x, y)
         tags = view.get_iter_at_location(x, y).get_tags()
         for tag in tags: