Merge lp:~brendan-donegan/checkbox/bug971181_next_button into lp:checkbox
Status: | Rejected |
---|---|
Rejected by: | Marc Tardif |
Proposed branch: | lp:~brendan-donegan/checkbox/bug971181_next_button |
Merge into: | lp:checkbox |
Diff against target: |
88 lines (+35/-2) 4 files modified
checkbox_qt/qt_interface.py (+7/-1) debian/changelog (+4/-0) qt/frontend/qtfront.cpp (+19/-1) qt/frontend/qtfront.h (+5/-0) |
To merge this branch: | bzr merge lp:~brendan-donegan/checkbox/bug971181_next_button |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jeff Lane | Disapprove | ||
Ara Pulido (community) | Needs Fixing | ||
Review via email:
|
Description of the change
Previously, when a test was run by clicking the 'Test' button in the Qt UI, and the appropriate 'Yes'/'No' result button was selected, if the user clicked on Next then they would still be warned about skipping the test. This seemed to be a little bit unintuitive for some people. I made a few changes to fix this so that if Next is pressed then the current state of the Yes/No buttons will be taken into account.
My concern here is that this fix feels like hackery, because we're essentially turning the push buttons into a sort of radio button.
I'd like some feedback on this proposed fix, to see if the approach is agreeable.
Unmerged revisions
- 1356. By Brendan Donegan
-
Fixed UI so that if the Yes/No button is highlighted automatically then the
appropriate result is marked for the test when Next is clicked (LP: #971181)
This wouldn't work in the cases where a test is manual, but you click Test to perform an action.
Example:
On the External Audio test, when you click on Test, Yes is automatically selected (as the script returns 0).
So, this does not seem like a solution for every case.
How many tests do we have that are semi-automated? I am starting to think that we may need to change the descriptions to match the new UI.