Merge lp:~brendan-donegan/checkbox/bug926104_cli_password_prompt into lp:checkbox

Proposed by Brendan Donegan
Status: Rejected
Rejected by: Brendan Donegan
Proposed branch: lp:~brendan-donegan/checkbox/bug926104_cli_password_prompt
Merge into: lp:checkbox
Diff against target: 26 lines (+3/-2)
2 files modified
checkbox_cli/cli_interface.py (+1/-2)
debian/changelog (+2/-0)
To merge this branch: bzr merge lp:~brendan-donegan/checkbox/bug926104_cli_password_prompt
Reviewer Review Type Date Requested Status
Brendan Donegan (community) Disapprove
Zygmunt Krynicki (community) Approve
Jeff Lane  Pending
Review via email: mp+126188@code.launchpad.net

Description of the change

Remove dots from CLI to avoid them getting in the way of the password prompt

To post a comment you must log in.
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

Heh, simple and easy!

Looks good to me

review: Approve
Revision history for this message
Brendan Donegan (brendan-donegan) wrote :

Thanks for the ack, but since the branch isn't actually *fixing* the problem so much as avoiding it, i'll put it as work in progress until JeffL can review it

Revision history for this message
Marc Tardif (cr3) wrote :

Would you mind if I have a look at the problem too?

Revision history for this message
Brendan Donegan (brendan-donegan) wrote :

Of course not

Revision history for this message
Brendan Donegan (brendan-donegan) wrote :

Already got a fix for this

review: Disapprove

Unmerged revisions

1694. By Brendan Donegan

Merged from trunk.

1693. By Brendan Donegan

checkbox_cli/cli_interface.py - remove dots from CLI to avoid them getting
in the way when being prompted for the sudo password (LP: #926104)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'checkbox_cli/cli_interface.py'
2--- checkbox_cli/cli_interface.py 2012-06-12 15:03:42 +0000
3+++ checkbox_cli/cli_interface.py 2012-09-25 08:28:23 +0000
4@@ -286,8 +286,7 @@
5
6 if progress != None:
7 self.put("\r%u%%" % (progress * 100))
8- else:
9- self.put(".")
10+
11 sys.stdout.flush()
12
13
14
15=== modified file 'debian/changelog'
16--- debian/changelog 2012-09-24 15:05:45 +0000
17+++ debian/changelog 2012-09-25 08:28:23 +0000
18@@ -127,6 +127,8 @@
19 * [FEATURE] jobs/power-management.txt.in, jobs/touchpad.txt.in,
20 jobs/sniff.txt.in - Fix incorrect formatting of job descriptions to
21 allow steps to be displayed by the UI (LP: #1054208)
22+ * checkbox_cli/cli_interface.py - remove dots from CLI to avoid them getting
23+ in the way when being prompted for the sudo password (LP: #926104)
24
25 [Sylvain Pineau]
26 * jobs/suspend.txt.in: Fixed suspend/suspend_advanced dependencies to avoid

Subscribers

People subscribed via source and target branches