Merge lp:~brendan-donegan/checkbox/bug911161_wake_alarm into lp:checkbox

Proposed by Brendan Donegan
Status: Merged
Merged at revision: 1159
Proposed branch: lp:~brendan-donegan/checkbox/bug911161_wake_alarm
Merge into: lp:checkbox
Diff against target: 27 lines (+3/-3)
2 files modified
debian/changelog (+1/-0)
scripts/sleep_test (+2/-3)
To merge this branch: bzr merge lp:~brendan-donegan/checkbox/bug911161_wake_alarm
Reviewer Review Type Date Requested Status
Jeff Lane  Approve
Review via email: mp+87329@code.launchpad.net

Description of the change

This merge changes the lines in sleep_test which deal with checking whether the wake_alarm is set from failing if the wake alarm is still set to only warning if it is

To post a comment you must log in.
Revision history for this message
Jeff Lane  (bladernr) wrote :

Looks good. Something I'd been meaning to fix for a while but it always got pushed aside. Glad you got it taken care of :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2011-12-21 17:26:41 +0000
3+++ debian/changelog 2012-01-03 11:19:25 +0000
4@@ -12,6 +12,7 @@
5 script to check automatically for a systems 'laptopness' (LP: #886668)
6 * Fixed connect_wireless script which continued failing to correctly
7 identify wireless connections.
8+ * Don't fail the sleep_test if the wake alarm is still set (LP: #911161)
9
10 [Gabor Kelemen]
11 * Fixed last two remaining strings with backslashes (LP: #868571)
12
13=== modified file 'scripts/sleep_test'
14--- scripts/sleep_test 2011-07-15 20:15:22 +0000
15+++ scripts/sleep_test 2012-01-03 11:19:25 +0000
16@@ -369,9 +369,8 @@
17 run_count += 1
18 if suspender.CheckAlarm(options.mode):
19 logging.debug('The alarm is still set')
20- run_result[run_count] = 'Fail'
21- else:
22- run_result[run_count] = 'Pass'
23+
24+ run_result[run_count] = 'Pass'
25
26 # Be reasonably sure the network is up before returning, we want
27 # the network to be up for possible following tests.

Subscribers

People subscribed via source and target branches