Merge lp:~brendan-donegan/checkbox/bug887049_usb_test into lp:checkbox
Proposed by
Brendan Donegan
Status: | Merged |
---|---|
Merged at revision: | 1119 |
Proposed branch: | lp:~brendan-donegan/checkbox/bug887049_usb_test |
Merge into: | lp:checkbox |
Diff against target: |
30 lines (+7/-3) 2 files modified
debian/changelog (+2/-0) scripts/usb_test (+5/-3) |
To merge this branch: | bzr merge lp:~brendan-donegan/checkbox/bug887049_usb_test |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Daniel Manrique (community) | Approve | ||
Review via email: mp+81855@code.launchpad.net |
Description of the change
Previously the usb_test script wasn't checking that the device in question actually had a path in the filesystem. This was causing an exception when the script was trying to read the non-existent path. This merge adds a guard around the statements which depend on the path existing.
To post a comment you must log in.
I tested on a USB drive containing multiple partitions (3 primary and one extended containing 2 logical partitions) and it handles them correctly. A problem remains when there are no write permissions but that's outside the scope of the linked bug, so I'm merging this as it works as intended. Thanks!